[PATCH 04/20] Add RACH message to PH-/MPH-/TCH-SAP interface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Sun Oct 6 20:48:53 UTC 2013


On Thu, Sep 19, 2013 at 2:11 PM, Andreas Eversberg <jolly at eversberg.eu> wrote:
> +       lc = &trx->ts[0].lchan[4].lapdm_ch;

I would recommend to move "trx->ts[0].lchan[4].lapdm_ch" to a macros
and document why do we refer to TS0, lchan 4 here (some references to
the would be helpful).

Otherwise this patch looks good to me from the code structure perspective.

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves LLC / ООО УмРадио
http://fairwaves.ru




More information about the OpenBSC mailing list