[PATCH] Use generic osmocom auth api

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Fri Nov 22 16:07:29 UTC 2013


Hi Max,

thanks for your patch.

I think it would make more sense to

1) add XOR to libosmocore
2) have a table or function to map from AUTH_ALGO_COMP128v1 to
   OSMO_AUTH_ALG_COMP128v1 (as well as mappings for any other ciphers

at that time, _use_xor() / _use_comp128_v1() become superfluous, and
auth_get_tuple_for_subscr() can call osmo_auth_gen_vec() directly.

This way, adding more algorithms only has to add mappings for the
AUTH_ALGO_* to OSMO_AUTH_ALG_ values (and a way how the vty can change
the algorithm for a given subscriber).

What do you think?

Regards,
	Harald

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the OpenBSC mailing list