[PATCH] Refactored tests to not ignore stderr.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Katerina Barone-Adesi kat.obsc at gmail.com
Tue Mar 12 10:21:44 UTC 2013 

It's probably worth checking if the ussd stderr output is correct.
---
 tests/lapd/lapd_test.err   |  4 ++++
 tests/testsuite.at         | 39 ++++++++++++++++++++++++++-------------
 tests/timer/timer_test.err |  6 ++++++
 tests/ussd/ussd_test.err   | 21 +++++++++++++++++++++
 4 files changed, 57 insertions(+), 13 deletions(-)
 create mode 100644 tests/lapd/lapd_test.err
 create mode 100644 tests/timer/timer_test.err
 create mode 100644 tests/ussd/ussd_test.err

diff --git a/tests/lapd/lapd_test.err b/tests/lapd/lapd_test.err
new file mode 100644
index 0000000..55bbd68
--- /dev/null
+++ b/tests/lapd/lapd_test.err
@@ -0,0 +1,4 @@
+<0001> lapd_core.c:886 Store content res.
+<0001> lapd_core.c:1735 writing an empty message is not possible.
+<0001> lapdm.c:1081 ((nil)) RLL Message 'REL_REQ' received without LAPDm context. (sapi 0)
+
\ No newline at end of file
diff --git a/tests/testsuite.at b/tests/testsuite.at
index 21fad1d..dc56517 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -6,7 +6,8 @@ AT_BANNER([Regression tests.])
 AT_SETUP([a5])
 AT_KEYWORDS([a5])
 cat $abs_srcdir/a5/a5_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/a5/a5_test], [], [expout])
+cat $abs_srcdir/a5/a5_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/a5/a5_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([bssgp-fc])
@@ -19,13 +20,15 @@ AT_CLEANUP
 AT_SETUP([bits])
 AT_KEYWORDS([bits])
 cat $abs_srcdir/bits/bitrev_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/bits/bitrev_test], [], [expout])
+cat $abs_srcdir/bits/bitrev_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/bits/bitrev_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([conv])
 AT_KEYWORDS([conv])
 cat $abs_srcdir/conv/conv_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/conv/conv_test], [], [expout])
+cat $abs_srcdir/conv/conv_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/conv/conv_test], [], [expout], [experr])
 AT_CLEANUP
 
 if ENABLE_MSGFILE
@@ -33,56 +36,65 @@ AT_SETUP([msgfile])
 AT_KEYWORDS([msgfile])
 cp $abs_srcdir/msgfile/msgconfig.cfg .
 cat $abs_srcdir/msgfile/msgfile_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test], [], [expout])
+cat $abs_srcdir/msgfile/msgfile_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/msgfile/msgfile_test], [], [expout], [experr])
 AT_CLEANUP
 endif
 
 AT_SETUP([sms])
 AT_KEYWORDS([sms])
 cat $abs_srcdir/sms/sms_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/sms/sms_test], [], [expout])
+cat $abs_srcdir/sms/sms_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/sms/sms_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([smscb])
 AT_KEYWORDS([smscb])
 cat $abs_srcdir/smscb/smscb_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/smscb/smscb_test], [], [expout])
+cat $abs_srcdir/smscb/smscb_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/smscb/smscb_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([timer])
 AT_KEYWORDS([timer])
 cat $abs_srcdir/timer/timer_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/timer/timer_test -s 5], [], [expout], [ignore])
+cat $abs_srcdir/timer/timer_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/timer/timer_test -s 5], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([ussd])
 AT_KEYWORDS([ussd])
 cat $abs_srcdir/ussd/ussd_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/ussd/ussd_test], [], [expout], [ignore])
+cat $abs_srcdir/ussd/ussd_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/ussd/ussd_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([auth])
 AT_KEYWORDS([auth])
 cat $abs_srcdir/auth/milenage_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/auth/milenage_test], [], [expout], [ignore])
+cat $abs_srcdir/auth/milenage_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/auth/milenage_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([lapd])
 AT_KEYWORDS([lapd])
 cat $abs_srcdir/lapd/lapd_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/lapd/lapd_test], [], [expout], [ignore])
+cat $abs_srcdir/lapd/lapd_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/lapd/lapd_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([gsm0808])
 AT_KEYWORDS([gsm0808])
 cat $abs_srcdir/gsm0808/gsm0808_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/gsm0808/gsm0808_test], [], [expout], [ignore])
+cat $abs_srcdir/gsm0808/gsm0808_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/gsm0808/gsm0808_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([gsm0408])
 AT_KEYWORDS([gsm0408])
 cat $abs_srcdir/gsm0408/gsm0408_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [ignore])
+cat $abs_srcdir/gsm0408/gsm0408_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/gsm0408/gsm0408_test], [], [expout], [experr])
 AT_CLEANUP
 
 AT_SETUP([logging])
@@ -110,5 +122,6 @@ AT_CLEANUP
 AT_SETUP([strrb])
 AT_KEYWORDS([strrb])
 cat $abs_srcdir/strrb/strrb_test.ok > expout
-AT_CHECK([$abs_top_builddir/tests/strrb/strrb_test], [], [expout], [ignore])
+cat $abs_srcdir/strrb/strrb_test.err > experr
+AT_CHECK([$abs_top_builddir/tests/strrb/strrb_test], [], [expout], [experr])
 AT_CLEANUP
diff --git a/tests/timer/timer_test.err b/tests/timer/timer_test.err
new file mode 100644
index 0000000..946bf49
--- /dev/null
+++ b/tests/timer/timer_test.err
@@ -0,0 +1,6 @@
+added 1 timers in step 0 (expired=0)
+added 2 timers in step 1 (expired=0)
+added 4 timers in step 2 (expired=0)
+added 8 timers in step 3 (expired=0)
+added 16 timers in step 4 (expired=3)
+Main timer has finished, please, wait a bit for the final report.
diff --git a/tests/ussd/ussd_test.err b/tests/ussd/ussd_test.err
new file mode 100644
index 0000000..774a357
--- /dev/null
+++ b/tests/ussd/ussd_test.err
@@ -0,0 +1,21 @@
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+<0000> gsm0480.c:299 Component does not fit.
+
\ No newline at end of file
-- 
1.8.1.4

More information about the OpenBSC mailing list