[PATCH] oml: Add a missing break switch for NM_OC_BS11

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at moiji-mobile.com
Sun Jul 14 05:55:53 UTC 2013


It appears to me that for NM_OC_BS11 mo was either NULL or the
one mo value from NM_OC_BS11_RACK. The break inside the nested
switch case didn't break from the outer one.

Fixes Coverity: CID 1040728
---
 openbsc/src/libcommon/gsm_data_shared.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/openbsc/src/libcommon/gsm_data_shared.c b/openbsc/src/libcommon/gsm_data_shared.c
index 9a50f6b..1b0814c 100644
--- a/openbsc/src/libcommon/gsm_data_shared.c
+++ b/openbsc/src/libcommon/gsm_data_shared.c
@@ -390,6 +390,7 @@ gsm_objclass2mo(struct gsm_bts *bts, uint8_t obj_class,
 		default:
 			return NULL;
 		}
+		break;
 	case NM_OC_BS11_RACK:
 		mo = &bts->bs11.rack.mo;
 		break;
-- 
1.8.3.2





More information about the OpenBSC mailing list