[PATCH] Add vty command for setting Access control classes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Ivan Kluchnikov Ivan.Kluchnikov at fairwaves.ru
Thu Jul 25 15:21:55 UTC 2013


2013/7/25 Holger Hans Peter Freyther <holger at freyther.de>

> On Thu, Jul 25, 2013 at 06:19:24PM +0400, Ivan Kluchnikov wrote:
>
> > - added 'write' implementation
>
> please write a VTY test for this routine. It is like 20 lines of
> python and will make sure that bitrot is detected early (a perfect
> way to secure your time investment).
>
>
Yes, I agree, tests are very important, I will try to write one for this
command.



>
> +       if ((bts->si_common.rach_control.t3) != 0)
> ...
>
> +       if ((bts->si_common.rach_control.t2 & 0xfb) != 0)
> ...
>
> you want to avoid executing the for loop?
>
> Yes, do you think it is redundant part of the code?


>
> holger
>
>


-- 
Regards,
Ivan Kluchnikov.
http://fairwaves.ru
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20130725/7e1a48bf/attachment.htm>


More information about the OpenBSC mailing list