[PATCH] Add vty command for setting Access control classes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Sat Jul 13 05:58:37 UTC 2013


On Fri, Jul 12, 2013 at 09:08:42PM +0400, Ivan Kluchnikov wrote:
> Hi all,
> 
> Attached patch adds vty command for setting Access control classes (GSM
> 02.11 Section 4 Access control) in RACH Control Parameters (GSM 04.08
> Section 10.5.2.29
> RACH Control Parameters).

Hi,

mutt doesn't allow me to comment on the patch (for inline patches this
always works, for some attachments it does work too.. not for yours).


My comments:

* Peter is right, and use "barred"|"allowed" as well instead of 0,1.
* The 'current' VTY rule is that unless there is a common prefix use
  '-' in the command. So it would be 'rach access-control-class" right
  now until we have someone else at 'access-control'..
* The code is missing a 'write' implementation.
* You might want to write a VTY test[1] to test if the command is taking
  effect on the SIs. You will need to create a subclass for the NITB.
* Please take a look at the kernel coding style
* Great to have this feature, for things like Fusion this is a useful
  addition!
* Great you patched pySIM for the ACC support.


thanks
	holger


[1] http://cgit.osmocom.org/openbsc/tree/openbsc/tests/vty_test_runner.py




More information about the OpenBSC mailing list