Coverity issues in lapd_core/gsm mncc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Andreas Eversberg andreas at eversberg.eu
Sun Jul 7 19:07:32 UTC 2013


Holger Hans Peter Freyther wrote:
> so maybe it simplifies the code just to assume/assert that the msgb
> is present in the primitive? As you freed the msgb, this means that
> OsmocomBB currently leaks this msgb during the handling of assignment?
hi holger,

lapdm.c takes the re-establishment message and forwards it to 
lapd_core.c, so we can assume that msg is set. i case there is data in 
the re-establishment msg, it is moved into send_buffer. in case of no 
data it must be freed. (currently i don't know why 
resume/re-establishment requires content in SABM message.)

regards,

andreas





More information about the OpenBSC mailing list