[PATCH] Added a ring buffer log target to store the last N log messages.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Sylvain Munaut 246tnt at gmail.com
Thu Feb 14 10:09:28 UTC 2013


Hi,

I didn't dig in the code deep yet, but one quick comment about the naming:

'ringbuffer' sounds a bit too generic to me when this implementation
is dedicated to strings. I would try to find something that illustrate
this specialization in the name (so that we don't conflict if we ever
have data ringbuffer or msgb ring buffer or whatever).

I think it should also have the osmo_ prefix in the function / struct names.

Just my 2ct.

Cheers,

    Sylvain




More information about the OpenBSC mailing list