This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Wed, Dec 18, 2013 at 12:54:51PM +0100, Jacob Erlbeck wrote: > +static int align_rtp_timestamp_offset(struct mgcp_endpoint *endp, The caller do not check the return value and there is a side-effect to state. I would change it to void. Same goes for align_rtp_timestamp_offset. > @@ -72,21 +72,21 @@ Out TS change: 160, dTS: 160, Seq change: 1, TS Err change: in +0, out +0 > In TS: 320, dTS: 160, Seq: 2 > Out TS change: 160, dTS: 160, Seq change: 1, TS Err change: in +0, out +0 > In TS: 320, dTS: 160, Seq: 3 > -Out TS change: 0, dTS: 160, Seq change: 1, TS Err change: in +1, out +1 > +Out TS change: 0, dTS: 160, Seq change: 1, TS Err change: in +0, out +0 What do you think about including the absolute time of the output as well? The other thing that I think is not tested with the data is re-ordering of packages? kind regards holger