Bug in range 512 encoding

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Andreas Eversberg andreas at eversberg.eu
Sun Dec 8 16:21:02 UTC 2013


diff --git a/openbsc/src/libbsc/arfcn_range_encode.c b/openbsc/src/libbsc/arfcn_range_encode.c
index 02a75a5..45a49da 100644
--- a/openbsc/src/libbsc/arfcn_range_encode.c
+++ b/openbsc/src/libbsc/arfcn_range_encode.c
@@ -213,7 +213,7 @@ int range_enc_range512(uint8_t *chan_list, int f0, int *w)
 	write_orig_arfcn(chan_list, f0);
 
 	range512 = (struct gsm48_range_512 *) &chan_list[0];
-	range512->form_id = chan_list[0] = 0x44;
+	range512->form_id = 0x44;
 
 	/* W(1) */
 	range512->w1_hi = HIGH_BITS(w, 1, 9, 7);


hi,

just found a bug in range 512 channel list encoding. the useless write of 0x44 to chan_list[0] will destroy the LSB, which is part of frequency 0, previously written by write_orig_arfcn(). after fixing this, a frequency of ARFCN 512 encodes correctly.

regards,

andreas






More information about the OpenBSC mailing list