[PATCH 2/4] Fix: Nokia requires VTY's "oml e1" parameters also

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Andreas Eversberg jolly at eversberg.eu
Thu Dec 5 15:02:37 UTC 2013


From: Andreas Eversberg <andreas at eversberg.eu>

When writing config file, OML configuration must be written for all
E1 based BTS, which includes Nokia *Site BTS.
---
 openbsc/src/libbsc/bsc_vty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index d03cafc..af0ecf9 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -601,7 +601,7 @@ static void config_write_bts_single(struct vty *vty, struct gsm_bts *bts)
 		break;
 	case GSM_BTS_TYPE_NOKIA_SITE:
 		vty_out(vty, "  nokia_site skip-reset %d%s", bts->nokia.skip_reset, VTY_NEWLINE);
-		break;
+		/* fall through: Nokia requires "oml e1" parameters also */
 	default:
 		config_write_e1_link(vty, &bts->oml_e1_link, "  oml ");
 		vty_out(vty, "  oml e1 tei %u%s", bts->oml_tei, VTY_NEWLINE);
-- 
1.7.3.4





More information about the OpenBSC mailing list