This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Tue, Aug 27, 2013 at 04:52:29PM +0200, Jacob Erlbeck wrote: Hi, looks good! some small details. > + if (data->ussd_msc_lost_txt) { > + talloc_free(data->ussd_msc_lost_txt); > + data->ussd_msc_lost_txt = 0; > + } you can avoid the branches. talloc_free(NULL) is well defined. > + suite.addTest(unittest.TestLoader().loadTestsFromTestCase(TestVTYBSC)) > add_nat_test(suite, workdir) the bsc is built conditionally, we will need to do something like it is done in add_nat_test. holger PS: I found an easy way to manually test your changes