[PATCH 1/2] vty: Fix misusage of snprintf in vty/utils.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Tue Aug 6 12:52:44 UTC 2013


On Tue, Aug 06, 2013 at 02:29:14PM +0200, Jacob Erlbeck wrote:

Hi,

thanks for compiling with ubuntu and creating a new test. :)

> +/* (C) 2013 by Jacob Erlbeck <jerlbeck at osmocom.de>
> + * All Rights Reserved

I think you want to use jerlbeck at sysmocom.de and I think something like
... by sysmocom s.f.m.c. Gmbh
Author: Jacob Erlbeck

is approriate.


> +static void init_vty(void)

> +static void free_vty(void)

we can skip that. :)

> +	// check against character strings that could break printf


that is C99/GNU extension. In general we are using the old C comments
with /* */


I will address all of the above before pushinh your patch.




More information about the OpenBSC mailing list