[PATCH] ipaccess: relax default behaviour on errors coming from signalling layer

[Pablo Neira Ayuso]

This patch relaxes the behaviour on error coming from the signalling
layer. This is probably too strict for recoverable errors.

Don't release msgb in this case, as this is controled by the signaling link
layer.

Thanks to Lennart Müller <mueller.lennart at googlemail.com> for the report.
---
 src/input/ipaccess.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index d63e796..c0c307e 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -450,10 +450,13 @@ static int handle_ts1_read(struct osmo_fd *bfd)
 		goto err_msg;
 	}
 	if (e1i_ts->line->ops->sign_link(msg) < 0) {
+		/* Don't close the signalling link if the upper layers report
+		 * an error, that's too strict. BTW, the signalling layer is
+		 * resposible for releasing the message.
+		 */
 		LOGP(DLINP, LOGL_ERROR, "Bad signalling message,"
 			"sign_link returned error\n");
 		ret = -EINVAL;
-		goto err;
 	}
 
 	return 0;
-- 
1.7.10.4


--ibTvN161/egqYuK8--