From ellen.apolinar.td at googlemail.com  Wed Jul  4 12:27:24 2012
From: ellen.apolinar.td at googlemail.com (Ellen Apolinar)
Date: Wed, 4 Jul 2012 14:27:24 +0200
Subject: OpenBSC + * + LCR -> Problems with LCR (--with-gsm-bs)
In-Reply-To: <CAGxkagYhBh1qzK2ZJV-dT2HZTE3Qy8c-0hqjmvik9ty=Ayhzxg@mail.gmail.com>
References: <CAAyk0ZRCqfgzd5O+7zd20LfTF+hw+Ard7ZY-eYUgHYsVic8MtA@mail.gmail.com>
	<4FE6B72C.1040208@eversberg.eu>
	<CAAyk0ZRdLSyWvxURA8gjCdmVzzrbAd3ugWHoYr=H6n8gpnVGQg@mail.gmail.com>
	<CAAyk0ZRKhVSRBjV0CQ9LSd4AJKQJJA5XvBrJ0vdLOFeLu8Sx-A@mail.gmail.com>
	<CAAyk0ZR952ft6=e4g26aMbWTYSMKMFxNLZTP1bAv7b70mGL+ug@mail.gmail.com>
	<CAGxkagYhBh1qzK2ZJV-dT2HZTE3Qy8c-0hqjmvik9ty=Ayhzxg@mail.gmail.com>
Message-ID: <CAAyk0ZRT9J8trTPiS65XKD+2SjR1v_-2dXcDJNrHAAU5YX6ZRg@mail.gmail.com>

Hello everybody,

I tried it again with mISDN and chan_lcr.

You can see the state here:
http://www.ip-phone-forum.de/showthread.php?t=247932&p=1842689&viewfull=1#post1842689

lcradmin state shows:

> GSM(port 1: mISDN_l1loop.1) TE ptp l2hold use:0  L2 unkn  L1 down
> GSM(port 2: mISDN_l1loop.2) NT ptp use:0  L2 UP  L1 UP
> Remote: asterisk
>

I loaded mISDN_l1loop with

> pri=1 nchannel=20
>


The connection between OpenBSC and LCR seems to work and with the help from
chan_lcr it seems that there is a connection between LCR and Asterisk
(lcradmin state -> "Remote: asterisk").

But I expected to see the hfc-e1 card in "lcradmin state" and not only
mISDN_l1loop. I have tried to change the interface.conf-file but that makes
thinks more confusion. Either I did it wrong or this was the wrong way.

Aside on that, is there a way to test OpenBSC + mISDN + LCR + Asterisk
without an ISDN phone or a hardware BTS? Actually there is no way to test
it with hardware except the HFC-E1 card.

Asterisk, OpenBSC and Telnet are working, also LCR. But I don't know if all
configurations are right and if it really would work if I connect a ISDN
phone or a BTS.

Thanks for your help.
Best regards
Ellen

P.S.: If someone could explain what exactly to do to work with sip +
chan_lcr it would be very appreciated because I also like to test it this
way.




2012/6/26 altaf sk <altaf329 at gmail.com>

> Hello all,
>
> I have cloned the lcr from the below link.
>
> Development git
>
> git clone git://git.misdn.eu/lcr.git/ -b master lcr-master
>
> Cloning from this git url i am able to get all the sip.cpp and sip.h
> header files. This gives me to do the configure along with sip.
>
> ./configure --without-asterisk --with-gsm-ms --with-sip
>
> But i loose when doing  the make.
>
> When I do 'make' it it produces following error.
>
> mISDN.cpp:61: error: aggregate ?mi_ext_fn_s myfn? has incomplete type and
> cannot be defined
> mISDN.cpp: In function ?int mISDN_initialize()?:
> mISDN.cpp:88: error: ?mISDN_set_debug_level? was not declared in this scope
> mISDN.cpp:90: error: ?mISDN_set_debug_level? was not declared in this scope
> make[1]: *** [mISDN.o] Error 1
> make[1]: Leaving directory `/root/catchercatcher/lcr-master'
>
> make: *** [all] Error 2
>
>
>
> Can someone kindly help me at this stage.
>
>
> Many thanks
>
> Regards,
>
> Altaf
> On Tue, Jun 26, 2012 at 4:42 PM, Ellen Apolinar <
> ellen.apolinar.td at googlemail.com> wrote:
>
>> The error is solved. This only happens if I start LCR and then OpenBSC
>> because with LCR OpenBSC is also started.
>>
>> Regards
>> Ellen
>>
>> 2012/6/26 Ellen Apolinar <ellen.apolinar.td at googlemail.com>
>>
>>> @Don: Thanks, yes, that was the problem. I didn't know that the version
>>> from linux-call-router.de is so old.
>>>
>>> @Mailinglist:
>>>
>>> I tried it again. And this time I installed it from git:
>>>
>>>> git clone git://git.misdn.eu/lcr.git/
>>>> cd /usr/src/lcr
>>>> ./configure ?without-asterisk --with-gsm-bs
>>>> make
>>>> make install
>>>>
>>>
>>> In the last installation I installed it from linux-call-router.de.
>>> Configuration with --with-sip wasn't available.
>>>
>>> lcr start:
>>>
>>>> ** LCR  Version 1.10
>>>>
>>>> ERROR Cannot get device information for port 1. (ioctl IMGETDEVINFO
>>>> failed ret=-1)
>>>> LCR 1.10 started, waiting for calls...
>>>>
>>>
>>> lcradmin state
>>>
>>>> Ext(port 0: hfc-e1.1) TE ptp l2hold use:0  L2 unkn  L1 unkn
>>>> Int (port 1: ) extension  not loaded
>>>>
>>>
>>>
>>> Also OpenBSC worked. Now I get this error massage:
>>>
>>>> ./osmo-nitb -c openbsc.cfg -C
>>>> 1 device found
>>>>         id:             0
>>>>         Dprotocols:     00000018
>>>>         Bprotocols:     0000006e
>>>>         protocol:       3
>>>>         nrbchan:        30
>>>>         name:           hfc-e1.1
>>>> could not bind l2 socket Device or resource busy
>>>> <0005> bsc_init.c:512 Error enabling E1 input driver
>>>>
>>>
>>> I don't know what is wrong and how I can solve this. Google wasn't very
>>> helpful in this case.
>>>
>>> And how can I connect LCR to OpenBSC?
>>>
>>> And what can I do with lcradmin state?
>>>
>>> Best regards
>>> Ellen
>>>
>>>
>>> 2012/6/26 Ellen Apolinar <ellen.apolinar.td at googlemail.com>
>>>
>>>> Hey Andreas,
>>>>
>>>> I try the way over SIP. But perhaps I make something wrong.
>>>>
>>>> What I want to do:
>>>>
>>>>> cd /usr/src/lcr
>>>>> ./configure --prefix=/usr/src/lcr --without-misdn --with-sip
>>>>>
>>>>
>>>> What I get:
>>>>
>>>>> configure: WARNING: unrecognized options: --without-misdn, --with-sip
>>>>>
>>>>
>>>> What I am able to do:
>>>>
>>>>> ./configure --prefix=/usr/src/lcr --with
>>>>> --with-asterisk    --with-gsm-ms      --with-PACKAGE
>>>>> --with-ssl
>>>>> --with-gsm-bs      --without-PACKAGE  --with-ss5
>>>>>
>>>>
>>>> Makefile:
>>>>
>>>>> ENABLE_ASTERISK_CHANNEL_DRIVER_FALSE = #
>>>>> ENABLE_ASTERISK_CHANNEL_DRIVER_TRUE =
>>>>> ENABLE_GSM_BS_FALSE = #
>>>>> ENABLE_GSM_BS_TRUE =
>>>>> ENABLE_GSM_FALSE = #
>>>>> ENABLE_GSM_MS_FALSE =
>>>>> ENABLE_GSM_MS_TRUE = #
>>>>> ENABLE_GSM_TRUE =
>>>>> ENABLE_SS5_FALSE =
>>>>> ENABLE_SS5_TRUE = #
>>>>>
>>>>
>>>> I change to:
>>>>
>>>>> ENABLE_ASTERISK_CHANNEL_DRIVER_FALSE = #
>>>>> ENABLE_ASTERISK_CHANNEL_DRIVER_TRUE =
>>>>> ENABLE_GSM_BS_FALSE =
>>>>> ENABLE_GSM_BS_TRUE = #
>>>>> ENABLE_GSM_FALSE = #
>>>>> ENABLE_GSM_MS_FALSE = #
>>>>> ENABLE_GSM_MS_TRUE =
>>>>> ENABLE_GSM_TRUE =
>>>>> ENABLE_SS5_FALSE =
>>>>> ENABLE_SS5_TRUE = #
>>>>>
>>>>
>>>> make:
>>>>
>>>>> make  all-am
>>>>> make[1]: Entering directory `/usr/src/lcr'
>>>>> gcc   -DWITH_GSM_BS -I./openbsc/include -I./libosmocore/include
>>>>> -I./openbsc   -Wall -DCONFIG_DATA="\"/usr/local/lcr\""
>>>>> -DSHARE_DATA="\"/usr/local/lcr\"" -DLOG_DIR="\"/usr/local/lcr\""
>>>>> -DEXTENSION_DATA="\"/usr/local/lcr/extensions\"" -D_GNU_SOURCE -fPIC -c
>>>>> chan_lcr.c -o chan_lcr.po
>>>>> chan_lcr.c: In function ?send_setup_to_lcr?:
>>>>> chan_lcr.c:644:12: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:655:12: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c: In function ?lcr_in_setup?:
>>>>> chan_lcr.c:858:2: warning: passing argument 9 of ?__ast_channel_alloc?
>>>>> makes integer from pointer without a cast [enabled by default]
>>>>> /usr/include/asterisk/channel.h:1118:2: note: expected ?int? but
>>>>> argument is of type ?char *?
>>>>> chan_lcr.c:883:6: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:885:6: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:887:6: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:890:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:893:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:896:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:900:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:903:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:906:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:909:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c: In function ?handle_queue?:
>>>>> chan_lcr.c:1707:18: error: incompatible types when assigning to type
>>>>> ?union ast_frame_subclass? from type ?char?
>>>>> chan_lcr.c: In function ?lcr_request?:
>>>>> chan_lcr.c:1820:2: warning: passing argument 9 of
>>>>> ?__ast_channel_alloc? makes integer from pointer without a cast [enabled by
>>>>> default]
>>>>> /usr/include/asterisk/channel.h:1118:2: note: expected ?int? but
>>>>> argument is of type ?char *?
>>>>> chan_lcr.c: In function ?lcr_call?:
>>>>> chan_lcr.c:1927:9: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1927:31: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1928:29: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1931:9: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1931:32: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1932:30: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1934:9: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1934:33: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1935:31: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c: In function ?lcr_write?:
>>>>> chan_lcr.c:2164:6: error: wrong type argument to unary exclamation mark
>>>>> chan_lcr.c:2166:20: error: invalid operands to binary & (have ?union
>>>>> ast_frame_subclass? and ?format_t?)
>>>>> chan_lcr.c: In function ?lcr_read?:
>>>>> chan_lcr.c:2229:25: error: incompatible types when assigning to type
>>>>> ?union ast_frame_subclass? from type ?format_t?
>>>>> chan_lcr.c: In function ?lcr_indicate?:
>>>>> chan_lcr.c:2274:8: warning: assignment from incompatible pointer type
>>>>> [enabled by default]
>>>>> chan_lcr.c:2289:8: warning: assignment from incompatible pointer type
>>>>> [enabled by default]
>>>>> chan_lcr.c:2316:8: warning: assignment from incompatible pointer type
>>>>> [enabled by default]
>>>>> chan_lcr.c:2381:14: error: dereferencing pointer to incomplete type
>>>>> chan_lcr.c:2382:33: error: dereferencing pointer to incomplete type
>>>>> chan_lcr.c: At top level:
>>>>> chan_lcr.c:2602:2: warning: initialization from incompatible pointer
>>>>> type [enabled by default]
>>>>> chan_lcr.c:2602:2: warning: (near initialization for
>>>>> ?lcr_tech.requester?) [enabled by default]
>>>>> chan_lcr.c: In function ?load_module?:
>>>>> chan_lcr.c:2818:2: warning: passing argument 2 of
>>>>> ?ast_register_application2? from incompatible pointer type [enabled by
>>>>> default]
>>>>> /usr/include/asterisk/module.h:458:5: note: expected ?int (*)(struct
>>>>> ast_channel *, const char *)? but argument is of type ?int (*)(struct
>>>>> ast_channel *, void *)?
>>>>> make[1]: *** [chan_lcr.po] Error 1
>>>>> make[1]: Leaving directory `/usr/src/lcr'
>>>>> make: *** [all] Error 2
>>>>>
>>>>
>>>> make install:
>>>>
>>>>> gcc   -DWITH_GSM_BS -I./openbsc/include -I./libosmocore/include
>>>>> -I./openbsc   -Wall -DCONFIG_DATA="\"/usr/local/lcr\""
>>>>> -DSHARE_DATA="\"/usr/local/lcr\"" -DLOG_DIR="\"/usr/local/lcr\""
>>>>> -DEXTENSION_DATA="\"/usr/local/lcr/extensions\"" -D_GNU_SOURCE -fPIC -c
>>>>> chan_lcr.c -o chan_lcr.po
>>>>> chan_lcr.c: In function ?send_setup_to_lcr?:
>>>>> chan_lcr.c:644:12: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:655:12: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c: In function ?lcr_in_setup?:
>>>>> chan_lcr.c:858:2: warning: passing argument 9 of ?__ast_channel_alloc?
>>>>> makes integer from pointer without a cast [enabled by default]
>>>>> /usr/include/asterisk/channel.h:1118:2: note: expected ?int? but
>>>>> argument is of type ?char *?
>>>>> chan_lcr.c:883:6: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:885:6: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:887:6: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:890:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:893:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:896:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:900:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:903:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:906:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c:909:7: error: ?struct ast_channel? has no member named ?cid?
>>>>> chan_lcr.c: In function ?handle_queue?:
>>>>> chan_lcr.c:1707:18: error: incompatible types when assigning to type
>>>>> ?union ast_frame_subclass? from type ?char?
>>>>> chan_lcr.c: In function ?lcr_request?:
>>>>> chan_lcr.c:1820:2: warning: passing argument 9 of
>>>>> ?__ast_channel_alloc? makes integer from pointer without a cast [enabled by
>>>>> default]
>>>>> /usr/include/asterisk/channel.h:1118:2: note: expected ?int? but
>>>>> argument is of type ?char *?
>>>>> chan_lcr.c: In function ?lcr_call?:
>>>>> chan_lcr.c:1927:9: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1927:31: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1928:29: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1931:9: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1931:32: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1932:30: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1934:9: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1934:33: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c:1935:31: error: ?struct ast_channel? has no member named
>>>>> ?cid?
>>>>> chan_lcr.c: In function ?lcr_write?:
>>>>> chan_lcr.c:2164:6: error: wrong type argument to unary exclamation mark
>>>>> chan_lcr.c:2166:20: error: invalid operands to binary & (have ?union
>>>>> ast_frame_subclass? and ?format_t?)
>>>>> chan_lcr.c: In function ?lcr_read?:
>>>>> chan_lcr.c:2229:25: error: incompatible types when assigning to type
>>>>> ?union ast_frame_subclass? from type ?format_t?
>>>>> chan_lcr.c: In function ?lcr_indicate?:
>>>>> chan_lcr.c:2274:8: warning: assignment from incompatible pointer type
>>>>> [enabled by default]
>>>>> chan_lcr.c:2289:8: warning: assignment from incompatible pointer type
>>>>> [enabled by default]
>>>>> chan_lcr.c:2316:8: warning: assignment from incompatible pointer type
>>>>> [enabled by default]
>>>>> chan_lcr.c:2381:14: error: dereferencing pointer to incomplete type
>>>>> chan_lcr.c:2382:33: error: dereferencing pointer to incomplete type
>>>>> chan_lcr.c: At top level:
>>>>> chan_lcr.c:2602:2: warning: initialization from incompatible pointer
>>>>> type [enabled by default]
>>>>> chan_lcr.c:2602:2: warning: (near initialization for
>>>>> ?lcr_tech.requester?) [enabled by default]
>>>>> chan_lcr.c: In function ?load_module?:
>>>>> chan_lcr.c:2818:2: warning: passing argument 2 of
>>>>> ?ast_register_application2? from incompatible pointer type [enabled by
>>>>> default]
>>>>> /usr/include/asterisk/module.h:458:5: note: expected ?int (*)(struct
>>>>> ast_channel *, const char *)? but argument is of type ?int (*)(struct
>>>>> ast_channel *, void *)?
>>>>>
>>>>
>>>> lcr start:
>>>>
>>>>> ** LCR  Version 1.7
>>>>>
>>>>> 000000 DEBUG (in getrulesetbyname() line 1871): ruleset main found.
>>>>> GSM is enabled, but not compiled. Use --with-gsm-bs or --with-gsm-ms
>>>>> while configure!
>>>>> --------------------- 2012.06.26 10:35:27 000001
>>>>>
>>>>> 000001 DEBUG (in join_free() line 99): no more pending join(s), done!
>>>>>
>>>>
>>>> Sofiasip is installed. Is there anything I forget so I can't configure
>>>> LCR with sip?
>>>>
>>>> Best regards.
>>>> Ellen
>>>>
>>>>
>>>> 2012/6/24 Andreas Eversberg <andreas at eversberg.eu>
>>>>
>>>>> Ellen Apolinar wrote:
>>>>>
>>>>>>
>>>>>> OpenBSC seems to work without errors but to connect it with asterisk
>>>>>> I need mISDN, mISDNuser and LCR.
>>>>>>
>>>>>>  hi,
>>>>>
>>>>> if you like to use lcr with gsm (bs or ms), then you cannot use
>>>>> asterisk channel driver. it only works with isdn. but you can use sip. in
>>>>> order to do that you may:
>>>>>
>>>>> - disable mISDN  (--without-misdn)
>>>>> - enable sip (--with-sip), you also need to have sipsofia installed
>>>>> - add a sip interface (see default/interface.conf). then everything is
>>>>> possible without mISDN, but you cannot use isdn phones/lines in this setup.
>>>>>
>>>>> example to just connect GSM and SIP interface without routing:
>>>>>
>>>>>  [GSM]
>>>>> gsm-bs
>>>>> tones yes
>>>>> earlyb no
>>>>> #rtp-bridge
>>>>> bridge SIP
>>>>>
>>>>>
>>>>> [SIP]
>>>>> sip <local ip>[:local sip port] <asterisk sip ip>[:asterisk sip port]
>>>>> tones no
>>>>> earlyb yes
>>>>> #rtp-bridge
>>>>> bridge GSM
>>>>>
>>>>> if asterisk and lcr run on the same machine, you need to change the
>>>>> sip port on asterisk or lcr side.
>>>>>
>>>>> if you like to use GSM codec on asterisk side, you may enable
>>>>> rtp-bridge. then the asterisk directly negotiates the codec with the phone.
>>>>> in this case GSM codec must be supported by asterisk. tested codecs
>>>>> are FR(standard) and EFR.
>>>>>
>>>>> regards,
>>>>>
>>>>> andreas
>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20120704/0d2e78fc/attachment.htm>

From ellen.apolinar.td at googlemail.com  Tue Jul 10 08:55:58 2012
From: ellen.apolinar.td at googlemail.com (Ellen Apolinar)
Date: Tue, 10 Jul 2012 10:55:58 +0200
Subject: OpenBSC -> only BTS+RNC+MSC+HLR without BSC possible?
In-Reply-To: <20120626051455.GA6306@prithivi.gnumonks.org>
References: <CAAyk0ZTEOBiyryqd9kOfyZGzHNz+Vif+HjR44ssZJOz1+Ph58w@mail.gmail.com>
	<20120622154704.GN9556@prithivi.gnumonks.org>
	<CAAyk0ZQDf2yWZZQr-iTwOsFC_wsgJhhqQ7oeQic8jDQZLewQcg@mail.gmail.com>
	<20120626051455.GA6306@prithivi.gnumonks.org>
Message-ID: <CAAyk0ZQu=W4Pd9YhVWUyaHGTuN5=hvRg8UtU1Zr_KmoLEYOvMw@mail.gmail.com>

Hi Harald,

sorry that you had to wait so a long time for an answer.

On Tue, Jun 26, 2012 at 7:14 AM, Harald Welte <laforge at gnumonks.org> wrote:

> Hi Ellen,
>
> On Mon, Jun 25, 2012 at 09:50:22AM +0200, Ellen Apolinar wrote:
> > > There are no BTS in UMTS.  There is no BSC in UMTS.  There's only
> NodeB,
> > > RNC.  As the Iub interface is completely unlike Abis, and UMTS (except
> > > call control and sms) is completely unlike GSM, I really don't
> > > understand what a BTS and a BSC would have to do with UMTS.
> >
> > We want to use it for GSM and UMTS. I know that UMTS is completely
> > different
> > and what I meant was BTS for GSM and NodeB for UMTS.
>
> > UMTS is more important than GSM for our project and I have to analyse
> > if it is possible to realise it also for UMTS. One of our programmers
> > will work for a half year at the projekt to realise it.
>
> If you have some resources to get external help/input with this, I
> suggest you talk to Dieter Spaar.  He has been wokring on a prototype
> implementation of a RNC for use with NSN and Ericsson NodeB's at some
> point in the past.
>
> If you don't need real NodeBs with Iub interface, femtocells might be an
> alternative.  Their Iuh or UMA/GAN interface is much less low-level, as
> they basically include most of the "RNC" part internally.
>

Yes, there are some resources to get help. I will write an e-mail to Dieter
Spaar to
tell him what I want to do.

I need real NodeBs because we want to test them with an own testing
environment.
Actually we use the Racal to transceive a signal to the BTS/NodeB and to
receive the answer
from the BTS/NodeB which is sent to the BSC/RNC.


>  > > If you are talking about a classic GSM BTS that speaks a dialect of
> > > A-bis RSL (08.58), adding support for them to OpenBSC shouldn be hard.
> > > Can you give us a list of BTS models that you're looking to support?
> >
> > We want to support following BTS/NodeB - models:
> >
> > Nokia: Citytalk, Ultrasite, Flexitalk
> > Siemes: BS60/61/21, BS240/241/40/41/82
>
> At least for Nokia and Siemens, it is definitely 08.58.  As we already
> support other Siemens and Nokia BTS, it is expected to be relatively
> easy to add support for the models you have indicated.


For testing OpenBSC with an BS60 can you tell me in a few sentences what
I/we
have to change? What else is to do except of changing the .swl-files?


> > Alcatel: G9100 Evolium, 63/64
>
> I have no information on their back-haul interface, so I cannot comment
> on the size of the effort.
>

>
 > Also Nortel GSM BTS. We got the traces from the Nokia Ultrasite and
> > Flexitalk, also from the Nortel18000. We have a T1/E1 Protocol Analyser:
> >
> > http://www.gl.com/laptopt1.html
>
> The protocol analyzer is only of help if it supports the decoding of the
> various BTS specific RSL and OML protocol dialects.  From my experience,
> Tektronix K15 is good in this area, but also is far short of decoding
> all information elements in any of the formats.
>
> Also, there's no need for tapping communicatoin between OpenBSC and the
> BTS.  That's what we have PCAP support for.
>
> What's most useful is if you will actually be able to take traces
> between the real BSC and the BTS.  Those traces then are the basis for
> adding OpenBSC support.  Without traces, I see only a very dim chance to
> add a BTS driver to OpenBSC.
>

The case is that we use the Racal, no real BSC, for testing the BTS. The
BSC and the
antenna are replaced by the racal. We got traces between BTS and Racal and
between
NodeB and RNC.


> > Yes, this is known here and I think it should be quite natural that we
> > release the code with our modifications if it works and share our
> > ideas with you.
>
> Ok.  We've had some bad experience about this in the past, so it's good
> to have this statement from you.  Please note that it would be good
> practise not to wait until everything works and then dump the code, but
> to actually develop it in an open git repository, where people can watch
> + provide feedback for every commit as you go.  The latter of course is
> not a legal requirement under AGPLv3, but it would be beneficial for you
> and for us.


My advisors know that if we modify the code we should share our experiences
with you and that there is a community who is interested in the changes of
the project and who, perhaps, can help us if there are problems.


> > > Based on past experience, I would say adding support for a new Abis
> > > variant is an effort somewhere between one and three man-weeks for a
> > > developer already familiar with OpenBSC internals and APIs.
> >
> > The project I work for is from a company so the purpose is that one of
> > the programmers works with us at the project and becomes familiar with
> > OpenBSC for making modifications so we could realise the connection
> > with our BTS and perhaps for UMTS.
>
> For the GSM BTS I see no problem. For UMTS, I would really see it as a
> completely separate/independent project, with probably at least 20 times
> the effort of your GSM project.  Also, the type of work is vastly
> different.  On the GSM side all the complex part is implemented and it
> is just putting in some BTS specific bits, as opposed to the UMTS side
> where you need to do everything from design/architecture/...
>

Yes, for UMTS it seems to become an own project.


 > But we have to know if it is achievable and if it is worth it. If it
> > is to unstable
>
> I'm not worried about it being unstable, but about the size of the
> effort.
>

It is possible to take some months of working for this project because it is
really important for the company to get a new test environment for the
BTS/NodeBs.


 We are currently doing some work in separating the core network part
> from the BSC part (having one program for MSC/HLR/AUC/SMSC and one for
> BSC, communicating via A-over-IP..  At that point, it might become
> fasible to re-use the MSC/HLR/AUC/SMSC part together with a
> to-be-written from scratch RNC.
>
> My suggestion would be to focus on GSM.
>
> Last, but not least, it would be interesting to know the purpose of your
> implementation / application.
>

The purpose is to test different BTS and NodeBs for errors so we can repair
them.
I study and I absolve my practical semester in a company which repairs BTS
and
NodeB from different producer.

I have read that there is a way to connect OpenBSC with OpenMSC. That's
also an
idea for a testing environment.


> Regards,
>         Harald
>
> --
> - Harald Welte <laforge at gnumonks.org>
> http://laforge.gnumonks.org/
>
> ============================================================================
> "Privacy in residential applications is a desirable marketing option."
>                                                   (ETSI EN 300 175-7 Ch.
> A6)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20120710/acadf0a8/attachment.htm>

From peter at stuge.se  Tue Jul 10 09:22:58 2012
From: peter at stuge.se (Peter Stuge)
Date: Tue, 10 Jul 2012 11:22:58 +0200
Subject: OpenBSC -> only BTS+RNC+MSC+HLR without BSC possible?
In-Reply-To: <CAAyk0ZQu=W4Pd9YhVWUyaHGTuN5=hvRg8UtU1Zr_KmoLEYOvMw@mail.gmail.com>
References: <CAAyk0ZTEOBiyryqd9kOfyZGzHNz+Vif+HjR44ssZJOz1+Ph58w@mail.gmail.com>
	<20120622154704.GN9556@prithivi.gnumonks.org>
	<CAAyk0ZQDf2yWZZQr-iTwOsFC_wsgJhhqQ7oeQic8jDQZLewQcg@mail.gmail.com>
	<20120626051455.GA6306@prithivi.gnumonks.org>
	<CAAyk0ZQu=W4Pd9YhVWUyaHGTuN5=hvRg8UtU1Zr_KmoLEYOvMw@mail.gmail.com>
Message-ID: <20120710092258.24774.qmail@stuge.se>

Ellen Apolinar wrote:
> My advisors know that if we modify the code we should share our experiences
> with you and that there is a community who is interested in the changes of
> the project and who, perhaps, can help us if there are problems.

I would suggest to communicate that the intent is very much that
everyone works together in the project. It is quite loosely
organized, but if some organization is required then it tends to
form naturally. It's important that your developers immerse
themselves in the project. Subscribe to this mailing list and
immediately publish every commit.

In return they will get feedback according to their level of work;
if they publish junior level commits then they will, best case, get
junior level feedback. If they publish senior level commits with
consistently high quality, beautiful code, then they will also get
advanced and intelligent feedback, and truly participate, which is
neccessary for a successful outcome of your project.

This requires an open, uninhibited, mindset at all organizational levels.


> The purpose is to test different BTS and NodeBs for errors so we
> can repair them.
> I study and I absolve my practical semester in a company which
> repairs BTS and NodeB from different producer.

I think this sounds like a fun and very fitting use of OpenBSC.

The fact that OpenBSC can be modified and customized so easily in
every part of the software makes for a perfect test suite foundation.


//Peter



From pfc.rivas at gmail.com  Tue Jul 24 11:01:49 2012
From: pfc.rivas at gmail.com (Arturo Rivas)
Date: Tue, 24 Jul 2012 13:01:49 +0200
Subject: Calls with OpenBSC+LCR+Asterisk
In-Reply-To: <CAFywq4-FGouta-ZRrM-j=LoowhgOeseVu-7twioJnx8eWSYRdA@mail.gmail.com>
References: <CA+_rdNeBSvytNS=0MLn4MhCTVPyxyNs2xowGNgXsGN8F97aiBQ@mail.gmail.com>
	<CAFywq4-FGouta-ZRrM-j=LoowhgOeseVu-7twioJnx8eWSYRdA@mail.gmail.com>
Message-ID: <CA+_rdNfbFG+v2uYt0ogXj48rZTYhf2c=nHjA7qvdafxp3Zyz1w@mail.gmail.com>

Thank you for help,

I've reinstall modules but it still doesn't work. Researching the above
error, dmesg shows:

*mISDN_dsp: Unknown symbol mISDN_clock_get (err 0)*

I've noticed that make command get some warnings in file clock.c which
contains mISDN_clock_get.

*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:116:1:
warning: data definition has no type or storage class [enabled by default]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:116:1:
warning: type defaults to ?int? in declaration of ?EXPORT_SYMBOL?
[-Wimplicit-int]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:116:1:
warning: parameter names (without types) in function declaration [enabled
by default]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:138:1:
warning: data definition has no type or storage class [enabled by default]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:138:1:
warning: type defaults to ?int? in declaration of ?EXPORT_SYMBOL?
[-Wimplicit-int]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:138:1:
warning: parameter names (without types) in function declaration [enabled
by default]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:191:1:
warning: data definition has no type or storage class [enabled by default]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:191:1:
warning: type defaults to ?int? in declaration of ?EXPORT_SYMBOL?
[-Wimplicit-int]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:191:1:
warning: parameter names (without types) in function declaration [enabled
by default]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:216:1:
warning: data definition has no type or storage class [enabled by default]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:216:1:
warning: type defaults to ?int? in declaration of ?EXPORT_SYMBOL?
[-Wimplicit-int]*
*/home/rivas/GSM/mISDN/standalone/drivers/isdn/mISDN/clock.c:216:1:
warning: parameter names (without types) in function declaration [enabled
by default]*

I don't know how to resolve that...

2012/6/25 Don Fanning <don at 00100100.net>

> *FATAL: Error inserting mISDN_dsp
> (/lib/modules/3.2.0-24-generic-pae/extra/mISDN_dsp.ko): Unknown symbol in
> module, or unknown parameter (see dmesg) *
> *
> *
> This means your modules do not match the kernel or associated libraries as
> the kernel sees symbols it has no idea how to interpret.  You need to clear
> out all the mISDN modules and start recompiling/installing again to make
> sure you have the matched modules being loaded.
>
> On Mon, Jun 25, 2012 at 10:11 AM, Arturo Rivas <pfc.rivas at gmail.com>wrote:
>
>> Did you load mISDN_dsp.ko?
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20120724/8d00442d/attachment.htm>

From george.news at gmx.net  Tue Jul 24 15:10:23 2012
From: george.news at gmx.net (George News)
Date: Tue, 24 Jul 2012 17:10:23 +0200
Subject: Calls with OpenBSC+LCR+Asterisk
Message-ID: <500EBADF.1070207@gmx.net>

Hi,

I'm trying to answer this question. I think the issue is just including 
<linux/export.h>.

Here is the additional patch attached. I think someone with access to 
wiki should update the mISDN.diff.

See you
Jorge
-------------- next part --------------
diff --git a/drivers/isdn/mISDN/clock.c b/drivers/isdn/mISDN/clock.c
index 1fa629b..7418f2d 100644
--- a/drivers/isdn/mISDN/clock.c
+++ b/drivers/isdn/mISDN/clock.c
@@ -38,6 +38,7 @@
 #include <linux/stddef.h>
 #include <linux/spinlock.h>
 #include <linux/mISDNif.h>
+#include <linux/export.h>
 #include "core.h"
 
 static u_int *debug;
diff --git a/drivers/isdn/mISDN/dsp_audio.c b/drivers/isdn/mISDN/dsp_audio.c
index 0afe9f2..735d535 100644
--- a/drivers/isdn/mISDN/dsp_audio.c
+++ b/drivers/isdn/mISDN/dsp_audio.c
@@ -10,6 +10,7 @@
  */
 
 #include <linux/delay.h>
+#include <linux/export.h>
 #include <linux/mISDNif.h>
 #include <linux/mISDNdsp.h>
 #include "core.h"

From alexander.huemer at xx.vu  Wed Jul  4 09:31:54 2012
From: alexander.huemer at xx.vu (Alexander Huemer)
Date: Wed,  4 Jul 2012 11:31:54 +0200
Subject: [PATCH] correct inverted logic from commit f3ba8a
In-Reply-To: <1341000089-570602-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341000089-570602-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341394314-17680-1-git-send-email-alexander.huemer@xx.vu>

---
 src/vty/vty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/vty/vty.c b/src/vty/vty.c
index 67ee100..e529ee7 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -1650,7 +1650,7 @@ static int vty_config_write(struct vty *vty)
 	vty_out(vty, "line vty%s", VTY_NEWLINE);
 
 	/* login */
-	if (password_check)
+	if (!password_check)
 		vty_out(vty, " no login%s", VTY_NEWLINE);
 
 	vty_out(vty, "!%s", VTY_NEWLINE);
-- 
1.7.2.5




From alexander.huemer at xx.vu  Wed Jul 11 08:45:58 2012
From: alexander.huemer at xx.vu (Alexander Huemer)
Date: Wed, 11 Jul 2012 10:45:58 +0200
Subject: [PATCH reminder] correct inverted logic from commit f3ba8a
In-Reply-To: <1341394314-17680-1-git-send-email-alexander.huemer@xx.vu>
References: <1341000089-570602-1-git-send-email-flameeyes@flameeyes.eu>
	<1341394314-17680-1-git-send-email-alexander.huemer@xx.vu>
Message-ID: <20120711084558.GD1263@de.xx.vu>

On Wed, Jul 04, 2012 at 11:31:54AM +0200, Alexander Huemer wrote:
> ---
>  src/vty/vty.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/vty/vty.c b/src/vty/vty.c
> index 67ee100..e529ee7 100644
> --- a/src/vty/vty.c
> +++ b/src/vty/vty.c
> @@ -1650,7 +1650,7 @@ static int vty_config_write(struct vty *vty)
>  	vty_out(vty, "line vty%s", VTY_NEWLINE);
>  
>  	/* login */
> -	if (password_check)
> +	if (!password_check)
>  		vty_out(vty, " no login%s", VTY_NEWLINE);
>  
>  	vty_out(vty, "!%s", VTY_NEWLINE);
> -- 
> 1.7.2.5
> 
Since a week has past since I submitted this patch and it was not yet
merged, here a short reminder. The problem was btw discussed with Diego
Elio Petten?, the author of the pristine commit.

Kind regards,
-Alexander Huemer



From laforge at gnumonks.org  Wed Jul 11 09:00:40 2012
From: laforge at gnumonks.org (Harald Welte)
Date: Wed, 11 Jul 2012 11:00:40 +0200
Subject: [PATCH reminder] correct inverted logic from commit f3ba8a
In-Reply-To: <20120711084558.GD1263@de.xx.vu>
References: <1341000089-570602-1-git-send-email-flameeyes@flameeyes.eu>
	<1341394314-17680-1-git-send-email-alexander.huemer@xx.vu>
	<20120711084558.GD1263@de.xx.vu>
Message-ID: <20120711090040.GK2490@prithivi.gnumonks.org>

> Since a week has past since I submitted this patch and it was not yet
> merged, here a short reminder. The problem was btw discussed with Diego
> Elio Petten?, the author of the pristine commit.

Sorry for the delays, patch has been merged!  Thanks for the catch.

Luckily we never really used the password feature anywhere, as far as I
can think.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



From peter at stuge.se  Sun Jul  1 01:00:01 2012
From: peter at stuge.se (Peter Stuge)
Date: Sun, 1 Jul 2012 03:00:01 +0200
Subject: [libosmo-abis PATCH 7/7] build: remove checks introduced by
	autoscan.
In-Reply-To: <1341094982-779038-7-git-send-email-flameeyes@flameeyes.eu>
References: <1341094982-779038-1-git-send-email-flameeyes@flameeyes.eu>
	<1341094982-779038-7-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <20120701010001.8798.qmail@stuge.se>

Diego Elio Petten? wrote:
> Therre is no current use of HAVE_* variables for these checks in the
> code, so there is no reason to keep the checks around.
> 
> Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>

All 7

Acked-by: Peter Stuge <peter at stuge.se>



From laforge at gnumonks.org  Sun Jul  1 05:43:48 2012
From: laforge at gnumonks.org (Harald Welte)
Date: Sun, 1 Jul 2012 07:43:48 +0200
Subject: [libosmo-abis PATCH 1/7] build: use LT_INIT([pic-only]) instead
	of forcing -fPIC in AM_CFLAGS.
In-Reply-To: <1341094982-779038-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341094982-779038-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <20120701054348.GA6079@prithivi.gnumonks.org>

Hi Diego,

On Sat, Jun 30, 2012 at 03:22:56PM -0700, Diego Elio Petten? wrote:
> Also contextually remove the AC_PROG_LIBTOOL call (which is an
> obsolete name for what is now LT_INIT).

[...]

Thanks, merged!

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



From flameeyes at flameeyes.eu  Wed Jul  4 11:15:46 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 04:15:46 -0700
Subject: [libosmo-dsp PATCH 1/5] build: flatten build to a single Makefile.am
Message-ID: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>

This is especially important because the library is so small, that
even the single recursion within src/ can have a (relative) overhead
on the whole build.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am                     |   16 +++++++++++++++-
 configure.ac                    |    4 ----
 include/Makefile.am             |    1 -
 include/osmocom/Makefile.am     |    1 -
 include/osmocom/dsp/Makefile.am |    3 ---
 src/Makefile.am                 |   11 -----------
 6 files changed, 15 insertions(+), 21 deletions(-)
 delete mode 100644 include/Makefile.am
 delete mode 100644 include/osmocom/Makefile.am
 delete mode 100644 include/osmocom/dsp/Makefile.am
 delete mode 100644 src/Makefile.am

diff --git a/Makefile.am b/Makefile.am
index ec16da9..de7600d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2,7 +2,6 @@ AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6
 ACLOCAL_AMFLAGS = -I m4
 
 INCLUDES = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src
 
 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = libosmodsp.pc
@@ -15,6 +14,21 @@ dist-hook:
 
 EXTRA_DIST = git-version-gen
 
+pkgincludedir = $(includedir)/osmocom/dsp
+pkginclude_HEADERS = include/osmocom/dsp/cxvec.h \
+                     include/osmocom/dsp/cfile.h \
+                     include/osmocom/dsp/cxvec_math.h
+
+# This is _NOT_ the library release version, it's an API version.
+# Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification
+LIBVERSION=0:0:0
+AM_CFLAGS = -fPIC -Wall -ffast-math
+
+lib_LTLIBRARIES = libosmodsp.la
+
+libosmodsp_la_SOURCES = src/cfile.c src/cxvec.c src/cxvec_math.c
+libosmodsp_la_LDFLAGS = -version-info $(LIBVERSION)
+
 if HAVE_DOXYGEN
 
 pkgdocdir=$(docdir)/$(PACKAGE)-$(VERSION)
diff --git a/configure.ac b/configure.ac
index 2e60a72..6ed54c6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -39,10 +39,6 @@ AM_CONFIG_HEADER(config.h)
 
 AC_OUTPUT(
 	libosmodsp.pc
-	include/Makefile
-	include/osmocom/Makefile
-	include/osmocom/dsp/Makefile
-	src/Makefile
 	Makefile
 	Doxyfile
 )
diff --git a/include/Makefile.am b/include/Makefile.am
deleted file mode 100644
index b255997..0000000
--- a/include/Makefile.am
+++ /dev/null
@@ -1 +0,0 @@
-SUBDIRS=osmocom
diff --git a/include/osmocom/Makefile.am b/include/osmocom/Makefile.am
deleted file mode 100644
index 8369d99..0000000
--- a/include/osmocom/Makefile.am
+++ /dev/null
@@ -1 +0,0 @@
-SUBDIRS=dsp
diff --git a/include/osmocom/dsp/Makefile.am b/include/osmocom/dsp/Makefile.am
deleted file mode 100644
index 5a6534f..0000000
--- a/include/osmocom/dsp/Makefile.am
+++ /dev/null
@@ -1,3 +0,0 @@
-osmodsp_HEADERS = cfile.h cxvec.h cxvec_math.h
-
-osmodspdir = $(includedir)/osmocom/dsp
diff --git a/src/Makefile.am b/src/Makefile.am
deleted file mode 100644
index 39a7429..0000000
--- a/src/Makefile.am
+++ /dev/null
@@ -1,11 +0,0 @@
-# This is _NOT_ the library release version, it's an API version.
-# Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification
-LIBVERSION=0:0:0
-
-INCLUDES = $(all_includes) -I$(top_srcdir)/include
-AM_CFLAGS = -fPIC -Wall -ffast-math
-
-lib_LTLIBRARIES = libosmodsp.la
-
-libosmodsp_la_SOURCES = cfile.c cxvec.c cxvec_math.c
-libosmodsp_la_LDFLAGS = -version-info $(LIBVERSION)
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 11:15:47 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 04:15:47 -0700
Subject: [libosmo-dsp PATCH 2/5] build: simplify Doxygen output installation
In-Reply-To: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341400550-373591-2-git-send-email-flameeyes@flameeyes.eu>

Instead of using a custom pkgdocdir value use the default, and
overridable, htmldir. Also make sure that the directory is properly
removed at uninstall, to unbreak `make distcheck`.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index de7600d..6b99f58 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -31,12 +31,9 @@ libosmodsp_la_LDFLAGS = -version-info $(LIBVERSION)
 
 if HAVE_DOXYGEN
 
-pkgdocdir=$(docdir)/$(PACKAGE)-$(VERSION)
-doc_htmldir=$(pkgdocdir)/html
+html_DATA = $(top_builddir)/doc/html.tar
 
-doc_html_DATA = $(top_builddir)/doc/html.tar
-
-$(doc_html_DATA): $(top_builddir)/doc/html/index.html
+$(html_DATA): $(top_builddir)/doc/html/index.html
 	cd $(top_builddir)/doc && tar cf html.tar html
 
 $(top_builddir)/doc/html/index.html: $(SOURCES) Doxyfile
@@ -45,10 +42,10 @@ $(top_builddir)/doc/html/index.html: $(SOURCES) Doxyfile
 	$(DOXYGEN) Doxyfile
 
 install-data-hook:
-	cd $(DESTDIR)$(doc_htmldir) && tar xf html.tar --strip-components 1 && rm -f html.tar
+	cd $(DESTDIR)$(htmldir) && tar xf html.tar --strip-components 1 && rm -f html.tar
 
 uninstall-hook:
-	cd $(DESTDIR) && rm -rf $(doc_htmldir)
+	rm -rf $(DESTDIR)$(htmldir)
 
 DX_CLEAN = doc/{html,latex}/* doc/html.tar
 
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 11:15:48 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 04:15:48 -0700
Subject: [libosmo-dsp PATCH 3/5] build: set automake options in configure.ac
	only.
In-Reply-To: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341400550-373591-3-git-send-email-flameeyes@flameeyes.eu>

Also disable building of gzip-compressed tarballs.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am  |    1 -
 configure.ac |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 6b99f58..27813e9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,3 @@
-AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6
 ACLOCAL_AMFLAGS = -I m4
 
 INCLUDES = $(all_includes) -I$(top_srcdir)/include
diff --git a/configure.ac b/configure.ac
index 6ed54c6..2d54fd1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @@ AC_INIT([libosmodsp],
         m4_esyscmd([./git-version-gen .tarball-version]),
         [gmr at lists.osmocom.org])
 
-AM_INIT_AUTOMAKE([dist-bzip2])
+AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.6])
 
 dnl kernel style compile messages
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 11:15:49 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 04:15:49 -0700
Subject: [libosmo-dsp PATCH 4/5] build: remove redundant AC_PROG_LIBTOOL and
	use LT_INIT(pic-only).
In-Reply-To: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341400550-373591-4-git-send-email-flameeyes@flameeyes.eu>


Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am  |    2 +-
 configure.ac |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 27813e9..3cd7cfc 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -21,7 +21,7 @@ pkginclude_HEADERS = include/osmocom/dsp/cxvec.h \
 # This is _NOT_ the library release version, it's an API version.
 # Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification
 LIBVERSION=0:0:0
-AM_CFLAGS = -fPIC -Wall -ffast-math
+AM_CFLAGS = -Wall -ffast-math
 
 lib_LTLIBRARIES = libosmodsp.la
 
diff --git a/configure.ac b/configure.ac
index 2d54fd1..052d2c9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11,8 +11,7 @@ dnl checks for programs
 AC_PROG_MAKE_SET
 AC_PROG_CC
 AC_PROG_INSTALL
-LT_INIT
-AC_PROG_LIBTOOL
+LT_INIT([pic-only])
 
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false)
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 11:15:50 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 04:15:50 -0700
Subject: [libosmo-dsp PATCH 5/5] build: avoid running unused checks
In-Reply-To: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341400550-373591-5-git-send-email-flameeyes@flameeyes.eu>

These tests are probably coming from autoscan and are not used in the
sources, so there is no reason to have them executed.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 configure.ac |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 052d2c9..c2108d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -18,10 +18,6 @@ AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false)
 
 AC_CONFIG_MACRO_DIR([m4])
 
-dnl checks for header files
-AC_HEADER_STDC
-AC_CHECK_HEADERS(complex.h math.h fcntl.h unistd.h sys/mman.h sys/types.h sys/stat.h)
-
 # The following test is taken from WebKit's webkit.m4
 saved_CFLAGS="$CFLAGS"
 CFLAGS="$CFLAGS -fvisibility=hidden "
-- 
1.7.8.6




From 246tnt at gmail.com  Wed Jul  4 11:52:32 2012
From: 246tnt at gmail.com (Sylvain Munaut)
Date: Wed, 4 Jul 2012 13:52:32 +0200
Subject: [libosmo-dsp PATCH 5/5] build: avoid running unused checks
In-Reply-To: <1341400550-373591-5-git-send-email-flameeyes@flameeyes.eu>
References: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
	<1341400550-373591-5-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <CAHL+j09ZdY_2QzB=zH0ZMZ0s4ju9JZRxfs2oX+fn5c7icyrnxw@mail.gmail.com>

On Wed, Jul 4, 2012 at 1:15 PM, Diego Elio Petten?
<flameeyes at flameeyes.eu> wrote:
> These tests are probably coming from autoscan and are not used in the
> sources, so there is no reason to have them executed.

Ideally I'd like configure to _fail_ completely if not found. Is there
a way to do that ?

Because I use those headers and rely on them to be present.

Cheers,

    Sylvain



From flameeyes at flameeyes.eu  Wed Jul  4 12:05:05 2012
From: flameeyes at flameeyes.eu (=?UTF-8?B?RGllZ28gRWxpbyBQZXR0ZW7Dsg==?=)
Date: Wed, 04 Jul 2012 14:05:05 +0200
Subject: [libosmo-dsp PATCH 5/5] build: avoid running unused checks
In-Reply-To: <CAHL+j09ZdY_2QzB=zH0ZMZ0s4ju9JZRxfs2oX+fn5c7icyrnxw@mail.gmail.com>
References: <1341400550-373591-1-git-send-email-flameeyes@flameeyes.eu>
	<1341400550-373591-5-git-send-email-flameeyes@flameeyes.eu>
	<CAHL+j09ZdY_2QzB=zH0ZMZ0s4ju9JZRxfs2oX+fn5c7icyrnxw@mail.gmail.com>
Message-ID: <4FF43171.5040303@flameeyes.eu>

Il 04/07/2012 13:52, Sylvain Munaut ha scritto:
> Ideally I'd like configure to _fail_ completely if not found. Is there
> a way to do that ?

There is, but I don't think that's a very good idea. Basically what
happens is that if the headers are not present, both before and after
this patch, the build will fail ? and it's much easier if you're porting
to an OS/combination to fix the issue if you get a build failure than a
configure failure (especially because often times the configure checks
end up bitrotting).

If you add a failure condition on the configure script, what you get is
a longer ./configure time on all systems (compared to after my patch)
and the same kind of build failure, just telling you that a header file
is missing.

My suggestion is to avoid all kind of checks that would be fatal unless
they can be overridden (like the pkg-config checks), or there is a
fallback available. Also if there is a fallback available I suggest
using a fallback-style check, like the one I describe at
http://goo.gl/OAxBt .

-- 
Diego Elio Petten? ? Flameeyes
flameeyes at flameeyes.eu ? http://blog.flameeyes.eu/





From flameeyes at flameeyes.eu  Wed Jul  4 12:15:20 2012
From: flameeyes at flameeyes.eu (=?UTF-8?B?RGllZ28gRWxpbyBQZXR0ZW7Dsg==?=)
Date: Wed, 04 Jul 2012 14:15:20 +0200
Subject: libosmo-sccp and static archives
Message-ID: <4FF433D8.3030900@flameeyes.eu>

Hello,

I was going on with the autotools cleanup (in order of listing in cgit)
but I'm a bit surprised about the libosmo-sccp structure, which
contrarily to libosmocore, libosmo-abis and libosmo-dsp is not using
libtool, but it's actually building three static archives, with one
source file each.

Now, I don't know if it might be too late to consider changing this but
I'm wondering why it has been done this way; when using a shared object
it might make sense (although the overhead of using more than one object
is probably higher than loading the unused code), but with static
archives all the Unix link editors I know only take by default only the
objects that are actually needed by what it's being linked; that is
using a single libosmo-sccp.a will only bring in the final linking the
object files that are actually needed.

I also wonder if it wouldn't make more sense to have everything built in
the same project/source tree with libosmocore ? in general this seems to
be small enough, and the time/space spent for these three files is
probably well recovered by the extra ./configure run that it has to run.

Let me know if I can be of help ? I'll still send the autotools cleanup
for this project today I think.

-- 
Diego Elio Petten? ? Flameeyes
flameeyes at flameeyes.eu ? http://blog.flameeyes.eu/




From laforge at gnumonks.org  Wed Jul  4 19:28:45 2012
From: laforge at gnumonks.org (Harald Welte)
Date: Wed, 4 Jul 2012 21:28:45 +0200
Subject: libosmo-sccp and static archives
In-Reply-To: <4FF433D8.3030900@flameeyes.eu>
References: <4FF433D8.3030900@flameeyes.eu>
Message-ID: <20120704192844.GI28906@prithivi.gnumonks.org>

Hi Diego,

On Wed, Jul 04, 2012 at 02:15:20PM +0200, Diego Elio Petten? wrote:
> I was going on with the autotools cleanup (in order of listing in cgit)
> but I'm a bit surprised about the libosmo-sccp structure, which
> contrarily to libosmocore, libosmo-abis and libosmo-dsp is not using
> libtool, but it's actually building three static archives, with one
> source file each.

I guess this is mostly for historic reasons.  Only Holger will know.

I personally would also think it makes sense to merge it into
libosmocore.  Holger?
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



From holger at freyther.de  Thu Jul  5 10:49:00 2012
From: holger at freyther.de (Holger Hans Peter Freyther)
Date: Thu, 5 Jul 2012 12:49:00 +0200
Subject: libosmo-sccp and static archives
In-Reply-To: <4FF433D8.3030900@flameeyes.eu>
References: <4FF433D8.3030900@flameeyes.eu>
Message-ID: <20120705104900.GD18088@sangmingze.sysmocom.de>

On Wed, Jul 04, 2012 at 02:15:20PM +0200, Diego Elio Petten? wrote:
> Hello,

Hi,

thanks for your cleanups. Let me answer the static archives.

static:
I have an application/use where having a DSO causes "issues". I know
that for Distros I should offer DSOs too.

multiple files:
Habbit, for WebKit copying 3GB in .o files into the .a because
one file changed.. lead me to create multipe libs. It is certainly
overkill for libosmo-sccp and having a single .a file would be okay.

holger



From flameeyes at flameeyes.eu  Thu Jul  5 10:57:57 2012
From: flameeyes at flameeyes.eu (=?UTF-8?B?RGllZ28gRWxpbyBQZXR0ZW7Dsg==?=)
Date: Thu, 05 Jul 2012 12:57:57 +0200
Subject: libosmo-sccp and static archives
In-Reply-To: <20120705104900.GD18088@sangmingze.sysmocom.de>
References: <4FF433D8.3030900@flameeyes.eu>
	<20120705104900.GD18088@sangmingze.sysmocom.de>
Message-ID: <4FF57335.7010809@flameeyes.eu>

Hi,

Il 05/07/2012 12:49, Holger Hans Peter Freyther ha scritto:
> I have an application/use where having a DSO causes "issues". I know
> that for Distros I should offer DSOs too.

Do you have more details on which issues it is? I've seen many problems
related to DSO before, but most of the time they are relatively easy to
fix, so if I can be of help I'd gladly do so.

> Habbit, for WebKit copying 3GB in .o files into the .a because
> one file changed.. lead me to create multipe libs. It is certainly
> overkill for libosmo-sccp and having a single .a file would be okay.

Sounds good then ? do you want me to send patches to set that one up,
with libtool or something?

If you use libtool, you can decide not to build the shared object simply
by using ./configure --disable-shared which then will only build the
static archives, if that's still a concern.

HTH,
-- 
Diego Elio Petten? ? Flameeyes
flameeyes at flameeyes.eu ? http://blog.flameeyes.eu/





From flameeyes at flameeyes.eu  Wed Jul  4 21:38:03 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:38:03 -0700
Subject: [libosmo-sccp PATCH 1/7] mtp_pcap: mark structure as constant as well
	as static.
Message-ID: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>


Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 src/mtp_pcap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mtp_pcap.c b/src/mtp_pcap.c
index 052813f..9b6de81 100644
--- a/src/mtp_pcap.c
+++ b/src/mtp_pcap.c
@@ -51,7 +51,7 @@ struct pcaprec_hdr {
 
 int mtp_pcap_write_header(int fd)
 {
-	static struct pcap_hdr hdr = {
+	static const struct pcap_hdr hdr = {
 		.magic_number	= 0xa1b2c3d4,
 		.version_major	= 2,
 		.version_minor	= 4,
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 21:38:04 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:38:04 -0700
Subject: [libosmo-sccp PATCH 2/7] m2ua: remove unset talloc context.
In-Reply-To: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341437889-626462-2-git-send-email-flameeyes@flameeyes.eu>

This might not be the correct approach, but right now the context is
always NULL, so remove the variable and push it as a constant instead.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 src/m2ua_msg.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/m2ua_msg.c b/src/m2ua_msg.c
index c04586f..af59376 100644
--- a/src/m2ua_msg.c
+++ b/src/m2ua_msg.c
@@ -26,14 +26,13 @@
 
 #include <string.h>
 
-static void *tall_m2ua;
 static int DM2UA = -1;
 
 struct m2ua_msg *m2ua_msg_alloc(void)
 {
 	struct m2ua_msg *msg;
 
-	msg = talloc_zero(tall_m2ua, struct m2ua_msg);
+	msg = talloc_zero(NULL, struct m2ua_msg);
 	if (!msg) {
 		LOGP(DM2UA, LOGL_ERROR, "Failed to allocate.\n");
 		return NULL;
-- 
1.7.8.6




From holger at freyther.de  Thu Jul  5 10:56:26 2012
From: holger at freyther.de (Holger Hans Peter Freyther)
Date: Thu, 5 Jul 2012 12:56:26 +0200
Subject: [libosmo-sccp PATCH 2/7] m2ua: remove unset talloc context.
In-Reply-To: <1341437889-626462-2-git-send-email-flameeyes@flameeyes.eu>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
	<1341437889-626462-2-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <20120705105626.GE18088@sangmingze.sysmocom.de>

On Wed, Jul 04, 2012 at 02:38:04PM -0700, Diego Elio Petten? wrote:
> This might not be the correct approach, but right now the context is
> always NULL, so remove the variable and push it as a constant instead.

Hi,

> -static void *tall_m2ua;

if the four/eight byte per instance bother too much right now, then please
use a define for now.

holger



From flameeyes at flameeyes.eu  Thu Jul  5 11:00:50 2012
From: flameeyes at flameeyes.eu (=?UTF-8?B?RGllZ28gRWxpbyBQZXR0ZW7Dsg==?=)
Date: Thu, 05 Jul 2012 13:00:50 +0200
Subject: [libosmo-sccp PATCH 2/7] m2ua: remove unset talloc context.
In-Reply-To: <20120705105626.GE18088@sangmingze.sysmocom.de>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
	<1341437889-626462-2-git-send-email-flameeyes@flameeyes.eu>
	<20120705105626.GE18088@sangmingze.sysmocom.de>
Message-ID: <4FF573E2.9070305@flameeyes.eu>

Il 05/07/2012 12:56, Holger Hans Peter Freyther ha scritto:
> if the four/eight byte per instance bother too much right now, then please
> use a define for now.

It's not for the bytes themselves (since it's uninitialised it's mapped
to the zero page, which means that it doesn't really use up space). It's
more about having code that seems to do one thing but is actually doing
another..

-- 
Diego Elio Petten? ? Flameeyes
flameeyes at flameeyes.eu ? http://blog.flameeyes.eu/





From flameeyes at flameeyes.eu  Wed Jul  4 21:38:05 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:38:05 -0700
Subject: [libosmo-sccp PATCH 3/7] build: flatten headers installation in
	include/Makefile.am
In-Reply-To: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341437889-626462-3-git-send-email-flameeyes@flameeyes.eu>

This avoids recursing multiple times for no reason.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 configure.ac             |    3 ---
 include/Makefile.am      |    8 +++++++-
 include/m2ua/Makefile.am |    2 --
 include/mtp/Makefile.am  |    2 --
 include/sccp/Makefile.am |    2 --
 5 files changed, 7 insertions(+), 10 deletions(-)
 delete mode 100644 include/m2ua/Makefile.am
 delete mode 100644 include/mtp/Makefile.am
 delete mode 100644 include/sccp/Makefile.am

diff --git a/configure.ac b/configure.ac
index 98a6b1f..ae35518 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,9 +31,6 @@ AC_SUBST(SYMBOL_VISIBILITY)
 AC_OUTPUT(
     libosmo-sccp.pc
     libosmo-mtp.pc
-    include/sccp/Makefile
-    include/mtp/Makefile
-    include/m2ua/Makefile
     include/Makefile
     src/Makefile
     tests/Makefile
diff --git a/include/Makefile.am b/include/Makefile.am
index 882d1e2..580d3a5 100644
--- a/include/Makefile.am
+++ b/include/Makefile.am
@@ -1 +1,7 @@
-SUBDIRS = sccp mtp m2ua
+pkgincludedir = $(includedir)/osmocom
+nobase_pkginclude_HEADERS = m2ua/m2ua_msg.h \
+                            m2ua/m2ua_types.h \
+                            mtp/mtp_level3.h \
+                            mtp/mtp_pcap.h \
+                            sccp/sccp.h \
+                            sccp/sccp_types.h
diff --git a/include/m2ua/Makefile.am b/include/m2ua/Makefile.am
deleted file mode 100644
index d740a6c..0000000
--- a/include/m2ua/Makefile.am
+++ /dev/null
@@ -1,2 +0,0 @@
-m2ua_HEADERS = m2ua_types.h m2ua_msg.h
-m2uadir = $(includedir)/osmocom/m2ua
diff --git a/include/mtp/Makefile.am b/include/mtp/Makefile.am
deleted file mode 100644
index dbd0e79..0000000
--- a/include/mtp/Makefile.am
+++ /dev/null
@@ -1,2 +0,0 @@
-mtp_HEADERS = mtp_level3.h mtp_pcap.h
-mtpdir = $(includedir)/osmocom/mtp
diff --git a/include/sccp/Makefile.am b/include/sccp/Makefile.am
deleted file mode 100644
index c64db26..0000000
--- a/include/sccp/Makefile.am
+++ /dev/null
@@ -1,2 +0,0 @@
-sccp_HEADERS = sccp_types.h sccp.h
-sccpdir = $(includedir)/osmocom/sccp
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 21:38:06 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:38:06 -0700
Subject: [libosmo-sccp PATCH 4/7] build: set automake options in configure.ac
	only.
In-Reply-To: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341437889-626462-4-git-send-email-flameeyes@flameeyes.eu>

Also disable building of gzip-compressed tarballs.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am  |    2 --
 configure.ac |    2 +-
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 51d65f8..5311609 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,5 +1,3 @@
-AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6
-
 INCLUDES = $(all_includes) -I$(top_srcdir)/include
 SUBDIRS = include src tests
 
diff --git a/configure.ac b/configure.ac
index ae35518..4de05f2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@ AC_INIT([libosmo-sccp],
 	m4_esyscmd([./git-version-gen .tarball-version]),
 	[openbsc at lists.osmocom.org])
 
-AM_INIT_AUTOMAKE([dist-bzip2])
+AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.6])
 AC_CONFIG_TESTDIR(tests)
 
 dnl kernel style compile messages
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 21:38:07 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:38:07 -0700
Subject: [libosmo-sccp PATCH 5/7] build: simplify test build
In-Reply-To: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341437889-626462-5-git-send-email-flameeyes@flameeyes.eu>

This makes the tests handling similar to the new one on libosmocore.
Please note that mtp/mtp_parse_test does not have to be declared
explicitly since it requires no library to be linked and the source
filename matches the target's name.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 .gitignore             |    1 +
 configure.ac           |    3 --
 tests/Makefile.am      |   54 +++++++++++++++++++++++++++++------------------
 tests/m2ua/Makefile.am |    8 -------
 tests/mtp/Makefile.am  |    6 -----
 tests/sccp/Makefile.am |   10 --------
 6 files changed, 34 insertions(+), 48 deletions(-)
 delete mode 100644 tests/m2ua/Makefile.am
 delete mode 100644 tests/mtp/Makefile.am
 delete mode 100644 tests/sccp/Makefile.am

diff --git a/.gitignore b/.gitignore
index 65fb1ef..7cd3da2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,7 @@
 *.o
 *.a
 .deps
+.dirstamp
 Makefile
 Makefile.in
 bscconfig.h
diff --git a/configure.ac b/configure.ac
index 4de05f2..9fb5f5b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,8 +34,5 @@ AC_OUTPUT(
     include/Makefile
     src/Makefile
     tests/Makefile
-    tests/sccp/Makefile
-    tests/mtp/Makefile
-    tests/m2ua/Makefile
     Makefile)
 
diff --git a/tests/Makefile.am b/tests/Makefile.am
index d005e7b..276d306 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,40 +1,52 @@
-SUBDIRS = sccp mtp m2ua
+INCLUDES = $(all_includes) -I$(top_srcdir)/include
+AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS)
 
 # The `:;' works around a Bash 3.2 bug when the output is not writeable.
 $(srcdir)/package.m4: $(top_srcdir)/configure.ac
 	:;{ \
-               echo '# Signature of the current package.' && \
-               echo 'm4_define([AT_PACKAGE_NAME],' && \
-               echo '  [$(PACKAGE_NAME)])' && \
-               echo 'm4_define([AT_PACKAGE_TARNAME],' && \
-               echo '  [$(PACKAGE_TARNAME)])' && \
-               echo 'm4_define([AT_PACKAGE_VERSION],' && \
-               echo '  [$(PACKAGE_VERSION)])' && \
-               echo 'm4_define([AT_PACKAGE_STRING],' && \
-               echo '  [$(PACKAGE_STRING)])' && \
-               echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \
-               echo '  [$(PACKAGE_BUGREPORT)])'; \
-               echo 'm4_define([AT_PACKAGE_URL],' && \
-               echo '  [$(PACKAGE_URL)])'; \
-             } >'$(srcdir)/package.m4'
-     
-EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE)
+	       echo '# Signature of the current package.' && \
+	       echo 'm4_define([AT_PACKAGE_NAME],' && \
+	       echo '  [$(PACKAGE_NAME)])' && \
+	       echo 'm4_define([AT_PACKAGE_TARNAME],' && \
+	       echo '  [$(PACKAGE_TARNAME)])' && \
+	       echo 'm4_define([AT_PACKAGE_VERSION],' && \
+	       echo '  [$(PACKAGE_VERSION)])' && \
+	       echo 'm4_define([AT_PACKAGE_STRING],' && \
+	       echo '  [$(PACKAGE_STRING)])' && \
+	       echo 'm4_define([AT_PACKAGE_BUGREPORT],' && \
+	       echo '  [$(PACKAGE_BUGREPORT)])'; \
+	       echo 'm4_define([AT_PACKAGE_URL],' && \
+	       echo '  [$(PACKAGE_URL)])'; \
+	     } >'$(srcdir)/package.m4'
+
+EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) \
+             m2ua/m2ua_test.ok mtp/mtp_parse_test.ok \
+             sccp/sccp_test.ok
+
 TESTSUITE = $(srcdir)/testsuite
-     
+
 check-local: atconfig $(TESTSUITE)
 	$(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
-     
+
 installcheck-local: atconfig $(TESTSUITE)
 	$(SHELL) '$(TESTSUITE)' AUTOTEST_PATH='$(bindir)' \
 		$(TESTSUITEFLAGS)
-     
+
 clean-local:
 	test ! -f '$(TESTSUITE)' || \
 		$(SHELL) '$(TESTSUITE)' --clean
 	$(RM) -f atconfig
-     
+
 AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te
 AUTOTEST = $(AUTOM4TE) --language=autotest
 $(TESTSUITE): $(srcdir)/testsuite.at $(srcdir)/package.m4
 	$(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at
 	mv $@.tmp $@
+
+check_PROGRAMS = m2ua/m2ua_test mtp/mtp_parse_test sccp/sccp_test
+
+m2ua_m2ua_test_SOURCES = m2ua/m2ua_test.c
+m2ua_m2ua_test_LDADD = $(top_builddir)/src/libm2ua.a $(LIBOSMOCORE_LIBS)
+
+sccp_sccp_test_SOURCES = sccp/sccp_test.c $(top_srcdir)/src/sccp.c
+sccp_sccp_test_LDADD = $(LIBOSMOCORE_LIBS)
diff --git a/tests/m2ua/Makefile.am b/tests/m2ua/Makefile.am
deleted file mode 100644
index 0eb8302..0000000
--- a/tests/m2ua/Makefile.am
+++ /dev/null
@@ -1,8 +0,0 @@
-INCLUDES = $(all_includes) -I$(top_srcdir)/include -Wall
-AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS)
-
-EXTRA_DIST = m2ua_test.ok
-
-noinst_PROGRAMS = m2ua_test
-m2ua_test_SOURCES = m2ua_test.c
-m2ua_test_LDADD = $(top_builddir)/src/libm2ua.a $(LIBOSMOCORE_LIBS)
diff --git a/tests/mtp/Makefile.am b/tests/mtp/Makefile.am
deleted file mode 100644
index 9e9292c..0000000
--- a/tests/mtp/Makefile.am
+++ /dev/null
@@ -1,6 +0,0 @@
-INCLUDES = $(all_includes) -I$(top_srcdir)/include -Wall
-noinst_PROGRAMS = mtp_parse_test
-
-EXTRA_DIST = mtp_parse_test.ok
-
-mtp_parse_test_SOURCES = mtp_parse_test.c
diff --git a/tests/sccp/Makefile.am b/tests/sccp/Makefile.am
deleted file mode 100644
index 90790a3..0000000
--- a/tests/sccp/Makefile.am
+++ /dev/null
@@ -1,10 +0,0 @@
-INCLUDES = $(all_includes) -I$(top_srcdir)/include
-AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS)
-
-EXTRA_DIST = sccp_test.ok
-
-noinst_PROGRAMS = sccp_test
-
-sccp_test_SOURCES = sccp_test.c $(top_srcdir)/src/sccp.c
-sccp_test_LDADD = $(LIBOSMOCORE_LIBS)
-
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 21:38:08 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:38:08 -0700
Subject: [libosmo-sccp PATCH 6/7] m2ua: accept a constant parameter in
	m2ua_from_msg.
In-Reply-To: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341437889-626462-6-git-send-email-flameeyes@flameeyes.eu>

This allows to use the function with constant arrays in the tests, the
content is never modified so this is not introducing any unexpected
behaviour.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 include/m2ua/m2ua_msg.h |    2 +-
 src/m2ua_msg.c          |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/m2ua/m2ua_msg.h b/include/m2ua/m2ua_msg.h
index e878edd..3a9da06 100644
--- a/include/m2ua/m2ua_msg.h
+++ b/include/m2ua/m2ua_msg.h
@@ -50,7 +50,7 @@ int m2ua_msg_add_data(struct m2ua_msg *msg, uint16_t tag, uint16_t len, uint8_t
 
 struct m2ua_msg_part *m2ua_msg_find_tag(struct m2ua_msg *msg, uint16_t tag);
 
-struct m2ua_msg *m2ua_from_msg(uint16_t len, uint8_t *data);
+struct m2ua_msg *m2ua_from_msg(uint16_t len, const uint8_t *data);
 struct msgb *m2ua_to_msg(struct m2ua_msg *msg);
 
 void m2ua_set_log_area(int log_area);
diff --git a/src/m2ua_msg.c b/src/m2ua_msg.c
index af59376..4ca83a0 100644
--- a/src/m2ua_msg.c
+++ b/src/m2ua_msg.c
@@ -83,7 +83,7 @@ struct m2ua_msg_part *m2ua_msg_find_tag(struct m2ua_msg *m2ua, uint16_t tag)
 	return NULL;
 }
 
-struct m2ua_msg *m2ua_from_msg(uint16_t len, uint8_t *data)
+struct m2ua_msg *m2ua_from_msg(uint16_t len, const uint8_t *data)
 {
 	struct m2ua_parameter_hdr *par;
 	struct m2ua_common_hdr *hdr;
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 21:38:09 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:38:09 -0700
Subject: [libosmo-sccp PATCH 7/7] tests: remove warnings and make more data
	constant.
In-Reply-To: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341437889-626462-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341437889-626462-7-git-send-email-flameeyes@flameeyes.eu>


Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 tests/m2ua/m2ua_test.c |   10 +++++-----
 tests/sccp/sccp_test.c |    3 ++-
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/tests/m2ua/m2ua_test.c b/tests/m2ua/m2ua_test.c
index d629ad5..b47bf5a 100644
--- a/tests/m2ua/m2ua_test.c
+++ b/tests/m2ua/m2ua_test.c
@@ -30,12 +30,12 @@
 		abort(); \
 	} while(0);
 
-static uint8_t asp_up[] = {
+static const uint8_t asp_up[] = {
 	0x01, 0x00, 0x03, 0x01, 0x00, 0x00, 0x00, 0x10,
 	0x00, 0x11, 0x00, 0x08, 0xac, 0x10, 0x01, 0x51,
 };
 
-static uint8_t data[] = {
+static const uint8_t data[] = {
 	0x01, 0x00, 0x06, 0x01, 0x00, 0x00, 0x00, 0x2c,
 	0x00, 0x01, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00,
 	0x03, 0x00, 0x00, 0x1a, 0x81, 0x5c, 0x00, 0x07,
@@ -49,12 +49,12 @@ static void test_asp_up(void)
 	struct m2ua_msg_part *part;
 	struct m2ua_msg *m2u = m2ua_from_msg(ARRAY_SIZE(asp_up), asp_up);
 	struct msgb *msg = m2ua_to_msg(m2u);
-	const uint8_t res[] = { 0xac, 0x10, 0x01, 0x51 };
+	static const uint8_t res[] = { 0xac, 0x10, 0x01, 0x51 };
 
 	printf("Testing ASP UP parsing.\n");
 
 	if (msg->len != ARRAY_SIZE(asp_up)) {
-		printf("Got %d wanted %d\n", msg->len, ARRAY_SIZE(asp_up));
+		printf("Got %d wanted %zu\n", msg->len, ARRAY_SIZE(asp_up));
 		FAIL("Wrong size");
 	}
 
@@ -84,7 +84,7 @@ static void test_data(void)
 	printf("Testing parsing of data.\n");
 
 	if (msg->len != ARRAY_SIZE(data)) {
-		printf("Got %d wanted %d\n", msg->len, ARRAY_SIZE(data));
+		printf("Got %d wanted %zu\n", msg->len, ARRAY_SIZE(data));
 		FAIL("Wrong size");
 	}
 
diff --git a/tests/sccp/sccp_test.c b/tests/sccp/sccp_test.c
index 7cff5d0..ea1b99b 100644
--- a/tests/sccp/sccp_test.c
+++ b/tests/sccp/sccp_test.c
@@ -991,7 +991,8 @@ static const struct log_info_cat default_categories[] = {
 	},
 };
 
-static int null_flt(void)
+static int null_flt(const struct log_context *ctx,
+		    struct log_target *tgt)
 {
 	return 1;
 }
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 21:42:15 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 14:42:15 -0700
Subject: [libosmocore PATCH] logging: accept a constant log_info_cat structure
	in log_info.
Message-ID: <1341438135-633290-1-git-send-email-flameeyes@flameeyes.eu>

This allows to use a statically-defined category (found in
libosmo-sccp's tests).

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 include/osmocom/core/logging.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h
index 76be100..ff456c2 100644
--- a/include/osmocom/core/logging.h
+++ b/include/osmocom/core/logging.h
@@ -101,7 +101,7 @@ struct log_info {
 	log_filter *filter_fn;
 
 	/*! \brief per-category information */
-	struct log_info_cat *cat;
+	const struct log_info_cat *cat;
 	/*! \brief total number of categories */
 	unsigned int num_cat;
 	/*! \brief total number of user categories (not library) */
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:40:06 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:40:06 -0700
Subject: [osmo-gmr PATCH 1/7] build: avoid recursing into include/ for
	non-installed headers.
Message-ID: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>

Instead of using recursive Makefile.am, declare all the headers on the
top-level Makefile.am, which will take care of all of them.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am                          |   21 ++++++++++++++++++++-
 configure.ac                         |    5 -----
 include/Makefile.am                  |    1 -
 include/osmocom/Makefile.am          |    1 -
 include/osmocom/gmr1/Makefile.am     |    3 ---
 include/osmocom/gmr1/l1/Makefile.am  |    3 ---
 include/osmocom/gmr1/sdr/Makefile.am |    1 -
 7 files changed, 20 insertions(+), 15 deletions(-)
 delete mode 100644 include/Makefile.am
 delete mode 100644 include/osmocom/Makefile.am
 delete mode 100644 include/osmocom/gmr1/Makefile.am
 delete mode 100644 include/osmocom/gmr1/l1/Makefile.am
 delete mode 100644 include/osmocom/gmr1/sdr/Makefile.am

diff --git a/Makefile.am b/Makefile.am
index c866969..5167991 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -2,7 +2,26 @@ AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6
 ACLOCAL_AMFLAGS = -I m4
 
 INCLUDES = $(all_includes) -I$(top_srcdir)/include
-SUBDIRS = include src
+SUBDIRS = src
+
+noinst_HEADERS = include/osmocom/gmr1/gsmtap.h \
+                 include/osmocom/gmr1/l1/a5.h \
+                 include/osmocom/gmr1/l1/bcch.h \
+                 include/osmocom/gmr1/l1/ccch.h \
+                 include/osmocom/gmr1/l1/conv.h \
+                 include/osmocom/gmr1/l1/crc.h \
+                 include/osmocom/gmr1/l1/defs.h \
+                 include/osmocom/gmr1/l1/facch3.h \
+                 include/osmocom/gmr1/l1/interleave.h \
+                 include/osmocom/gmr1/l1/punct.h \
+                 include/osmocom/gmr1/l1/rach.h \
+                 include/osmocom/gmr1/l1/scramb.h \
+                 include/osmocom/gmr1/l1/tch3.h \
+                 include/osmocom/gmr1/sdr/defs.h \
+                 include/osmocom/gmr1/sdr/dkab.h \
+                 include/osmocom/gmr1/sdr/fcch.h \
+                 include/osmocom/gmr1/sdr/nb.h \
+                 include/osmocom/gmr1/sdr/pi4cxpsk.h
 
 BUILT_SOURCES = $(top_srcdir)/.version
 $(top_srcdir)/.version:
diff --git a/configure.ac b/configure.ac
index 60c850b..a4f3952 100644
--- a/configure.ac
+++ b/configure.ac
@@ -42,11 +42,6 @@ dnl Generate the output
 AM_CONFIG_HEADER(config.h)
 
 AC_OUTPUT(
-	include/Makefile
-	include/osmocom/Makefile
-	include/osmocom/gmr1/Makefile
-	include/osmocom/gmr1/l1/Makefile
-	include/osmocom/gmr1/sdr/Makefile
 	src/Makefile
 	src/l1/Makefile
 	src/sdr/Makefile
diff --git a/include/Makefile.am b/include/Makefile.am
deleted file mode 100644
index 3578a80..0000000
--- a/include/Makefile.am
+++ /dev/null
@@ -1 +0,0 @@
-SUBDIRS = osmocom
diff --git a/include/osmocom/Makefile.am b/include/osmocom/Makefile.am
deleted file mode 100644
index 950eae8..0000000
--- a/include/osmocom/Makefile.am
+++ /dev/null
@@ -1 +0,0 @@
-SUBDIRS = gmr1
diff --git a/include/osmocom/gmr1/Makefile.am b/include/osmocom/gmr1/Makefile.am
deleted file mode 100644
index 91c5c44..0000000
--- a/include/osmocom/gmr1/Makefile.am
+++ /dev/null
@@ -1,3 +0,0 @@
-SUBDIRS = l1 sdr
-
-noinst_HEADERS = gsmtap.h
diff --git a/include/osmocom/gmr1/l1/Makefile.am b/include/osmocom/gmr1/l1/Makefile.am
deleted file mode 100644
index 40f2bd2..0000000
--- a/include/osmocom/gmr1/l1/Makefile.am
+++ /dev/null
@@ -1,3 +0,0 @@
-noinst_HEADERS = \
-	conv.h crc.h interleave.h punct.h scramb.h \
-	a5.h bcch.h ccch.h rach.h facch3.h tch3.h
diff --git a/include/osmocom/gmr1/sdr/Makefile.am b/include/osmocom/gmr1/sdr/Makefile.am
deleted file mode 100644
index 03c9769..0000000
--- a/include/osmocom/gmr1/sdr/Makefile.am
+++ /dev/null
@@ -1 +0,0 @@
-noinst_HEADERS = defs.h dkab.h fcch.h nb.h pi4cxpsk.h
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:40:07 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:40:07 -0700
Subject: [osmo-gmr PATCH 2/7] build: simplify building by avoiding recursion
	in src/.
In-Reply-To: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341441612-717632-2-git-send-email-flameeyes@flameeyes.eu>

Only the l1 subdirectory's sources are shared between the two
binaries, so build those into a static archive and link it in both.
The sdr sources are compiled in directly.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 configure.ac        |    2 --
 src/Makefile.am     |   17 +++++++++--------
 src/l1/Makefile.am  |    9 ---------
 src/sdr/Makefile.am |    7 -------
 4 files changed, 9 insertions(+), 26 deletions(-)
 delete mode 100644 src/l1/Makefile.am
 delete mode 100644 src/sdr/Makefile.am

diff --git a/configure.ac b/configure.ac
index a4f3952..87cfc79 100644
--- a/configure.ac
+++ b/configure.ac
@@ -43,8 +43,6 @@ AM_CONFIG_HEADER(config.h)
 
 AC_OUTPUT(
 	src/Makefile
-	src/l1/Makefile
-	src/sdr/Makefile
 	Makefile
 	Doxyfile
 )
diff --git a/src/Makefile.am b/src/Makefile.am
index c3991ae..a1f8c9b 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,15 +1,16 @@
-SUBDIRS = l1 sdr
-
 INCLUDES = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
 AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMODSP_CFLAGS)
-AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMODSP_LIBS)
 
+noinst_LIBRARIES = libl1.a
 bin_PROGRAMS = gmr1_rx gmr1_gen_mat
 
-gmr1_rx_SOURCES = gmr1_rx.c gsmtap.c
-gmr1_rx_LDADD =	$(top_builddir)/src/l1/libgmr1-l1.a \
-		$(top_builddir)/src/sdr/libgmr1-sdr.a \
-		$(FFTW3F_LIBS)
+libl1_a_SOURCES = l1/conv.c l1/crc.c l1/interleave.c l1/punct.c		\
+                  l1/scramb.c l1/a5.c l1/bcch.c l1/ccch.c l1/rach.c	\
+                  l1/facch3.c l1/tch3.c
+
+gmr1_rx_SOURCES = gmr1_rx.c gsmtap.c sdr/dkab.c sdr/fcch.c sdr/nb.c	\
+                  sdr/pi4cxpsk.c
+gmr1_rx_LDADD =	libl1.a $(LIBOSMOCORE_LIBS) $(LIBOSMODSP_LIBS) $(FFTW3F_LIBS)
 
 gmr1_gen_mat_SOURCES = gmr1_gen_mat.c
-gmr1_gen_mat_LDADD = $(top_builddir)/src/l1/libgmr1-l1.a
+gmr1_gen_mat_LDADD = libl1.a $(LIBOSMOCORE_LIBS)
diff --git a/src/l1/Makefile.am b/src/l1/Makefile.am
deleted file mode 100644
index 3ef01a3..0000000
--- a/src/l1/Makefile.am
+++ /dev/null
@@ -1,9 +0,0 @@
-INCLUDES = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
-AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS)
-AM_LDFLAGS = $(LIBOSMOCORE_LIBS)
-
-noinst_LIBRARIES = libgmr1-l1.a
-
-libgmr1_l1_a_SOURCES = \
-	conv.c crc.c interleave.c punct.c scramb.c \
-	a5.c bcch.c ccch.c rach.c facch3.c tch3.c
diff --git a/src/sdr/Makefile.am b/src/sdr/Makefile.am
deleted file mode 100644
index df1d2d3..0000000
--- a/src/sdr/Makefile.am
+++ /dev/null
@@ -1,7 +0,0 @@
-INCLUDES = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
-AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMODSP_CFLAGS) $(FFTW3F_CFLAGS)
-AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMODSP_LIBS) $(FFTW3F_LIBS)
-
-noinst_LIBRARIES = libgmr1-sdr.a
-
-libgmr1_sdr_a_SOURCES = dkab.c fcch.c nb.c pi4cxpsk.c
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:40:08 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:40:08 -0700
Subject: [osmo-gmr PATCH 3/7] gmr1_rx: remove to variables set but not used
In-Reply-To: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341441612-717632-3-git-send-email-flameeyes@flameeyes.eu>

This removes two warnings but it might better test the result instead
of just ignoring it.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 src/gmr1_rx.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/gmr1_rx.c b/src/gmr1_rx.c
index d48acad..dd028c7 100644
--- a/src/gmr1_rx.c
+++ b/src/gmr1_rx.c
@@ -311,7 +311,7 @@ _rx_tch3_facch(struct chan_desc *cd, struct osmo_cxvec *burst)
 {
 	struct tch3_state *st = &cd->tch_state;
 	sbit_t ebits[104];
-	int rv, bi, sync_id;
+	int bi, sync_id;
 	float toa;
 
 	/* Burst index */
@@ -321,7 +321,7 @@ _rx_tch3_facch(struct chan_desc *cd, struct osmo_cxvec *burst)
 	fprintf(stderr, "[.]   FACCH3 (bi=%d)\n", bi);
 
 	/* Demodulate burst */
-	rv = gmr1_pi4cxpsk_demod(
+	gmr1_pi4cxpsk_demod(
 		&gmr1_nt3_facch_burst,
 		burst, cd->sps, -cd->freq_err,
 		ebits, &sync_id, &toa, NULL
@@ -352,14 +352,14 @@ _rx_tch3_speech(struct chan_desc *cd, struct osmo_cxvec *burst)
 	sbit_t ebits[212];
 	ubit_t sbits[4], ciph[208];
 	uint8_t frame0[10], frame1[10];
-	int rv, conv[2];
+	int conv[2];
 	float toa;
 
 	/* Debug */
 	fprintf(stderr, "[.]   TCH3\n");
 
 	/* Demodulate burst */
-	rv = gmr1_pi4cxpsk_demod(
+	gmr1_pi4cxpsk_demod(
 		&gmr1_nt3_speech_burst,
 		burst, cd->sps, -cd->freq_err,
 		ebits, NULL, &toa, NULL
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:40:09 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:40:09 -0700
Subject: [osmo-gmr PATCH 4/7] build: simplify documentation install.
In-Reply-To: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341441612-717632-4-git-send-email-flameeyes@flameeyes.eu>

This simplifies the Makefile and uses the overridable htmldir setting
instead.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 5167991..f5f703d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -33,12 +33,9 @@ EXTRA_DIST = git-version-gen
 
 if HAVE_DOXYGEN
 
-pkgdocdir=$(docdir)/$(PACKAGE)-$(VERSION)
-doc_htmldir=$(pkgdocdir)/html
+html_DATA = $(top_builddir)/doc/html.tar
 
-doc_html_DATA = $(top_builddir)/doc/html.tar
-
-$(doc_html_DATA): $(top_builddir)/doc/html/index.html
+$(html_DATA): $(top_builddir)/doc/html/index.html
 	cd $(top_builddir)/doc && tar cf html.tar html
 
 $(top_builddir)/doc/html/index.html: $(SOURCES) Doxyfile
@@ -47,10 +44,10 @@ $(top_builddir)/doc/html/index.html: $(SOURCES) Doxyfile
 	$(DOXYGEN) Doxyfile
 
 install-data-hook:
-	cd $(DESTDIR)$(doc_htmldir) && tar xf html.tar --strip-components 1 && rm -f html.tar
+	cd $(DESTDIR)$(htmldir) && tar xf html.tar --strip-components 1 && rm -f html.tar
 
 uninstall-hook:
-	cd $(DESTDIR) && rm -rf $(doc_htmldir)
+	rm -rf $(DESTDIR)$(htmldir)
 
 DX_CLEAN = doc/{html,latex}/* doc/html.tar
 
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:40:10 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:40:10 -0700
Subject: [osmo-gmr PATCH 5/7] build: remove unused test and get rid of libtool.
In-Reply-To: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341441612-717632-5-git-send-email-flameeyes@flameeyes.eu>

The project is not building any library and is not relying on the .la
files from other libraries, so there is no reason to use libtool in
this context.

Since libtool is gone, there is no reason to keep m4 around anymore.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am   |    1 -
 configure.ac  |    8 +-------
 m4/.gitignore |    2 --
 3 files changed, 1 insertions(+), 10 deletions(-)
 delete mode 100644 m4/.gitignore

diff --git a/Makefile.am b/Makefile.am
index f5f703d..152ca98 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,5 +1,4 @@
 AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6
-ACLOCAL_AMFLAGS = -I m4
 
 INCLUDES = $(all_includes) -I$(top_srcdir)/include
 SUBDIRS = src
diff --git a/configure.ac b/configure.ac
index 87cfc79..61d7a24 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11,22 +11,16 @@ dnl checks for programs
 AC_PROG_MAKE_SET
 AC_PROG_CC
 AC_PROG_INSTALL
-LT_INIT
-AC_PROG_LIBTOOL
+AC_PROG_RANLIB
 
 AC_PATH_PROG(DOXYGEN,doxygen,false)
 AM_CONDITIONAL(HAVE_DOXYGEN, test $DOXYGEN != false)
 
-AC_CONFIG_MACRO_DIR([m4])
-
 dnl checks for libraries
 PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.4.1)
 PKG_CHECK_MODULES(LIBOSMODSP, libosmodsp)
 PKG_CHECK_MODULES(FFTW3F, fftw3f >= 3.2.0)
 
-dnl checks for header files
-AC_HEADER_STDC
-
 # The following test is taken from WebKit's webkit.m4
 saved_CFLAGS="$CFLAGS"
 CFLAGS="$CFLAGS -fvisibility=hidden "
diff --git a/m4/.gitignore b/m4/.gitignore
deleted file mode 100644
index 64d9bbc..0000000
--- a/m4/.gitignore
+++ /dev/null
@@ -1,2 +0,0 @@
-/libtool.m4
-/lt*.m4
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:40:11 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:40:11 -0700
Subject: [osmo-gmr PATCH 6/7] build: move automake options to configure.ac
In-Reply-To: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341441612-717632-6-git-send-email-flameeyes@flameeyes.eu>


Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am  |    2 --
 configure.ac |    2 +-
 2 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 152ca98..1127e5b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,5 +1,3 @@
-AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6
-
 INCLUDES = $(all_includes) -I$(top_srcdir)/include
 SUBDIRS = src
 
diff --git a/configure.ac b/configure.ac
index 61d7a24..5c25351 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @@ AC_INIT([osmo-gmr],
         m4_esyscmd([./git-version-gen .tarball-version]),
         [gmr at lists.osmocom.org])
 
-AM_INIT_AUTOMAKE([dist-bzip2])
+AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip 1.6])
 
 dnl kernel style compile messages
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:40:12 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:40:12 -0700
Subject: [osmo-gmr PATCH 7/7] gitignore: ignore src/gmr1_gen_mat as well.
In-Reply-To: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341441612-717632-7-git-send-email-flameeyes@flameeyes.eu>


Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 .gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/.gitignore b/.gitignore
index b34624d..3047cf1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,3 +33,4 @@ Doxyfile
 
 doc/
 src/gmr1_rx
+src/gmr1_gen_mat
-- 
1.7.8.6




From 246tnt at gmail.com  Wed Jul  4 23:18:37 2012
From: 246tnt at gmail.com (Sylvain Munaut)
Date: Thu, 5 Jul 2012 01:18:37 +0200
Subject: [osmo-gmr PATCH 1/7] build: avoid recursing into include/ for
	non-installed headers.
In-Reply-To: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <CAHL+j08_j06fR9oT1LJ_JEwSk2Gotuo8qc0ZrrPUa9EgG3Koyw@mail.gmail.com>

Hi,

Just fyi I'll look at those (for osmo-gmr and libosmo-dsp) in detail
over the weekend.

I'll have to see exactly what they do because the state of the repo
might not reflect what I have in mind for the future. (for eg I see
the gmr1 code become a library with the installed headers, or even if
l1 is the only one used in both binary in the public repo, I still
have some test / future binary that depend on both sdr/ and l1/ ...
things like that).

In general I'm not a big fan of the flattening ... I kinda like that
each repo is responsible for defining it's own source files. Beside
build speed (which for me is not really an argument given it's so
small), what are the advantages ?

Cheers,

    Sylvain



From laforge at gnumonks.org  Thu Jul  5 05:56:40 2012
From: laforge at gnumonks.org (Harald Welte)
Date: Thu, 5 Jul 2012 07:56:40 +0200
Subject: [osmo-gmr PATCH 1/7] build: avoid recursing into include/ for
	non-installed headers.
In-Reply-To: <CAHL+j08_j06fR9oT1LJ_JEwSk2Gotuo8qc0ZrrPUa9EgG3Koyw@mail.gmail.com>
References: <1341441612-717632-1-git-send-email-flameeyes@flameeyes.eu>
	<CAHL+j08_j06fR9oT1LJ_JEwSk2Gotuo8qc0ZrrPUa9EgG3Koyw@mail.gmail.com>
Message-ID: <20120705055640.GN28906@prithivi.gnumonks.org>

Hi Sylvain,

On Thu, Jul 05, 2012 at 01:18:37AM +0200, Sylvain Munaut wrote:

> In general I'm not a big fan of the flattening ... I kinda like that
> each repo is responsible for defining it's own source files. Beside
> build speed (which for me is not really an argument given it's so
> small), what are the advantages ?

I personally like the 'flattening' idea to some extent, especially since
you don't have to add another 'Makefile' line to configure.ac and do a
full autoreconf/configure/make cycle every time you add one file to the
repository.  I haven't tried it, but I suppose now it is sufficient to
simply add the file to Makefile.am, and a simple "make" will notice it,
regenerate Makefile and build.

So I'm not sure if the benefit of having Makefile.[am,in] for each
subdirectory (especially the empty ones like 'include' which just state
a single SUBDIR line) really is the better approach.

But of course, for your code / repositories you maintain, it is your
decision, I just wanted to share some thoughts.

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



From flameeyes at flameeyes.eu  Wed Jul  4 22:57:04 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:57:04 -0700
Subject: [sam7-util PATCH 1/2] build: update autotools to modern standards.
Message-ID: <1341442625-721583-1-git-send-email-flameeyes@flameeyes.eu>

This includes removing AC_CANONICAL_BUILD/AC_CANONICAL_TARGET (weren't
used), renaming configure.in to configure.ac (required for automake
1.13 coming up), moving automake options to configure.ac (removes use
of AM_INIT_AUTOMAKE with two parameters, which is also gone with
automake 1.13).

Also remove empty files and declare the system foreign, not gnu (NEWS
and AUTHORS are not used), avoid re-declaring in the distributed files
the conditional sources (automake takes care of that), and don't use
-Werror (as it would fail to build with GCC 4.6 and 4.7).

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 Makefile.am  |    7 ++-----
 configure.ac |   43 +++++++++++++++++++++++++++++++++++++++++++
 configure.in |   46 ----------------------------------------------
 3 files changed, 45 insertions(+), 51 deletions(-)
 delete mode 100644 AUTHORS
 delete mode 100644 NEWS
 create mode 100644 configure.ac
 delete mode 100644 configure.in

diff --git a/AUTHORS b/AUTHORS
deleted file mode 100644
index e69de29..0000000
diff --git a/Makefile.am b/Makefile.am
index ae59bd6..7d6aaf8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,6 +1,4 @@
-AM_CFLAGS = -Wall -Werror
-
-AUTOMAKE_OPTIONS = gnu
+AM_CFLAGS = -Wall
 
 bin_PROGRAMS = sam7
 
@@ -22,6 +20,5 @@ endif
 noinst_HEADERS = io.h samba.h cmd.h loader128_data.h loader256_data.h 
 
 EXTRA_DIST = driver/Makefile driver/at91.c \
-	io_win32.c io_posix.c io_iokit.c io_libusb.c\
 	loader/Makefile loader/at91.h loader/bin2c.c loader/crt0.S \
-	loader/loader.c loader/loader.lds
\ No newline at end of file
+	loader/loader.c loader/loader.lds
diff --git a/NEWS b/NEWS
deleted file mode 100644
index e69de29..0000000
diff --git a/configure.ac b/configure.ac
new file mode 100644
index 0000000..e16b1ed
--- /dev/null
+++ b/configure.ac
@@ -0,0 +1,43 @@
+AC_INIT([sam7utils], [0.2.1], [konkers at konkers.net])
+
+AC_CANONICAL_HOST
+
+AM_INIT_AUTOMAKE(foreign)
+AM_CONFIG_HEADER(config.h)
+
+AC_PROG_CC 
+AC_PROG_INSTALL
+AC_PROG_MAKE_SET
+
+case "${host}" in
+     *-*-darwin* )
+       LIBS="$LIBS -framework IOKIT -framework CoreFoundation"
+       have_iokit="true"
+     ;;	    
+     *-*-cygwin* )
+       LIBS="$LIBS -lsetupapi"
+       have_win32="true"
+     ;;	    
+     * )
+       have_posix="true"
+       AC_CHECK_LIB(usb,usb_init,have_libusb="true";LIBS="$LIBS -lusb")
+       
+     ;;
+esac
+
+
+AC_HEADER_STDC
+
+AC_CHECK_LIB(readline, readline,,AC_MSG_ERROR(readline not found))
+AC_CHECK_LIB(curses, tgoto,,AC_MSG_ERROR(curses not found))
+AC_CHECK_HEADERS(stdint.h,,AC_MSG_WARN(can't find stdint.h))
+AC_CHECK_HEADERS(ctype.h,,)
+AC_CHECK_HEADERS(endian.h,,)
+
+
+AM_CONDITIONAL([HAVE_IOKIT], [test x$have_iokit = xtrue])
+AM_CONDITIONAL([HAVE_WIN32], [test x$have_win32 = xtrue])
+AM_CONDITIONAL([HAVE_POSIX], [test x$have_posix = xtrue])
+AM_CONDITIONAL([HAVE_LIBUSB],[test x$have_libusb = xtrue])
+
+AC_OUTPUT(Makefile)
diff --git a/configure.in b/configure.in
deleted file mode 100644
index 4a5a8b3..0000000
--- a/configure.in
+++ /dev/null
@@ -1,46 +0,0 @@
-AC_INIT([sam7utils], [0.2.1], [konkers at konkers.net])
-
-AC_CANONICAL_BUILD
-AC_CANONICAL_HOST
-AC_CANONICAL_TARGET
-
-AM_INIT_AUTOMAKE(sam7utils,0.2.1)
-AM_CONFIG_HEADER(config.h)
-
-
-AC_PROG_CC 
-AC_PROG_INSTALL
-AC_PROG_MAKE_SET
-
-case "${host}" in
-     *-*-darwin* )
-       LIBS="$LIBS -framework IOKIT -framework CoreFoundation"
-       have_iokit="true"
-     ;;	    
-     *-*-cygwin* )
-       LIBS="$LIBS -lsetupapi"
-       have_win32="true"
-     ;;	    
-     * )
-       have_posix="true"
-       AC_CHECK_LIB(usb,usb_init,have_libusb="true";LIBS="$LIBS -lusb")
-       
-     ;;
-esac
-
-
-AC_HEADER_STDC
-
-AC_CHECK_LIB(readline, readline,,AC_MSG_ERROR(readline not found))
-AC_CHECK_LIB(curses, tgoto,,AC_MSG_ERROR(curses not found))
-AC_CHECK_HEADERS(stdint.h,,AC_MSG_WARN(can't find stdint.h))
-AC_CHECK_HEADERS(ctype.h,,)
-AC_CHECK_HEADERS(endian.h,,)
-
-
-AM_CONDITIONAL([HAVE_IOKIT], [test x$have_iokit = xtrue])
-AM_CONDITIONAL([HAVE_WIN32], [test x$have_win32 = xtrue])
-AM_CONDITIONAL([HAVE_POSIX], [test x$have_posix = xtrue])
-AM_CONDITIONAL([HAVE_LIBUSB],[test x$have_libusb = xtrue])
-
-AC_OUTPUT(Makefile)
-- 
1.7.8.6




From flameeyes at flameeyes.eu  Wed Jul  4 22:57:05 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Wed,  4 Jul 2012 15:57:05 -0700
Subject: [sam7-util PATCH 2/2] io.c: remove warning on format string.
In-Reply-To: <1341442625-721583-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341442625-721583-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <1341442625-721583-2-git-send-email-flameeyes@flameeyes.eu>


Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 io.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/io.c b/io.c
index 165962b..851e54a 100644
--- a/io.c
+++ b/io.c
@@ -22,7 +22,7 @@ static int last_driver = 0;
 int io_driver_register(struct io_driver *driver)
 {
 	if (last_driver > ARRAY_SIZE(drivers)) {
-		fprintf(stderr, "Registered more than %d devices.\n",
+		fprintf(stderr, "Registered more than %zu devices.\n",
 			ARRAY_SIZE(drivers));
 		return -1;
 	}
-- 
1.7.8.6




From holger at freyther.de  Sun Jul  8 14:50:29 2012
From: holger at freyther.de (Holger Hans Peter Freyther)
Date: Sun, 8 Jul 2012 16:50:29 +0200
Subject: [sam7-util PATCH 1/2] build: update autotools to modern standards.
In-Reply-To: <1341442625-721583-1-git-send-email-flameeyes@flameeyes.eu>
References: <1341442625-721583-1-git-send-email-flameeyes@flameeyes.eu>
Message-ID: <20120708145029.GC7374@sangmingze.sysmocom.de>

On Wed, Jul 04, 2012 at 03:57:04PM -0700, Diego Elio Petten? wrote:

Hi,

please use -M for git format-patch to properly detect renames. I am
applying both patches now.

thanks

holger



From flameeyes at flameeyes.eu  Thu Jul  5 10:09:59 2012
From: flameeyes at flameeyes.eu (=?UTF-8?q?Diego=20Elio=20Petten=C3=B2?=)
Date: Thu,  5 Jul 2012 03:09:59 -0700
Subject: [libasn1c PATCH] src: avoid pointer casting warnings.
Message-ID: <1341482999-807642-1-git-send-email-flameeyes@flameeyes.eu>

These easily cause safety checks to go off as they can represent
64-bit-unsafe code, but in this case they are minor changes required.

Signed-off-by: Diego Elio Petten? <flameeyes at flameeyes.eu>
---
 src/constr_SET_OF.c |    2 +-
 src/per_support.c   |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/constr_SET_OF.c b/src/constr_SET_OF.c
index 11eac57..8e376e6 100644
--- a/src/constr_SET_OF.c
+++ b/src/constr_SET_OF.c
@@ -915,7 +915,7 @@ SET_OF_decode_uper(asn_codec_ctx_t *opt_codec_ctx, asn_TYPE_descriptor_t *td,
 			nelems = uper_get_length(pd,
 				ct ? ct->effective_bits : -1, &repeat);
 			ASN_DEBUG("Got to decode %d elements (eff %d)",
-				(int)nelems, (int)ct ? ct->effective_bits : -1);
+				(int)nelems, ct != NULL ? ct->effective_bits : -1);
 			if(nelems < 0) _ASN_DECODE_STARVED;
 		}
 
diff --git a/src/per_support.c b/src/per_support.c
index 173e696..e891a0e 100644
--- a/src/per_support.c
+++ b/src/per_support.c
@@ -13,9 +13,9 @@ per_data_string(asn_per_data_t *pd) {
 	static int n;
 	n = (n+1) % 2;
 	snprintf(buf[n], sizeof(buf),
-		"{m=%d span %+d[%d..%d] (%d)}",
+		"{m=%zu span %+d[%zu..%zu] (%zu)}",
 		pd->moved,
-		(((int)pd->buffer) & 0xf),
+		 (int)(((ptrdiff_t)pd->buffer) & 0xf),
 		pd->nboff, pd->nbits,
 		pd->nbits - pd->nboff);
 	return buf[n];
@@ -106,7 +106,7 @@ per_get_few_bits(asn_per_data_t *pd, int nbits) {
 	ASN_DEBUG("  [PER got %2d<=%2d bits => span %d %+d[%d..%d]:%02x (%d) => 0x%x]",
 		nbits, nleft,
 		pd->moved,
-		(((int)pd->buffer) & 0xf),
+		(((ptrdiff_t)pd->buffer) & 0xf),
 		pd->nboff, pd->nbits,
 		pd->buffer[0],
 		pd->nbits - pd->nboff,
-- 
1.7.8.6




From spaar at mirider.augusta.de  Tue Jul 10 10:14:15 2012
From: spaar at mirider.augusta.de (Dieter Spaar)
Date: Tue, 10 Jul 2012 10:14:15 CEST
Subject: Nokia TETRA device configuration ?
Message-ID: <4ffc0077.mirider@mirider.augusta.de>

Hallo Harald,

On Tue, 10 Jul 2012 09:49:22 +0200, "Harald Welte" <laforge at gnumonks.org> wrote:
> 
> ich habs auch mal unter meinem namen auf finetopix.com gepostet, mal
> sehen ob eine antwort kommt.

Danke. Es gibt doch ein paar Leute aus dem Osmo-Umfeld die so ein Geraet
haben. Steve und Dimitri habe sich eines auf meinen Vorschlag hin gekauft
und Alexander Huemer hat wohl ebenfalls ein aelteres Nokia TETRA Geraet.

BTW, der Dolphin TETRA Handset von Africar kann eventuell mit einer
Standard Motorola Firmware umgeflasht werden. Damit soll es dann
DMO koennen. Es gibt unterschiedliche Aussagen dazu, man muesste
es wohl ausprobieren. Africar hat laut ebay vier Stueck davon (neu)
und will EUR 98 bzw. Preisvorschlag. Es wuerde sich daher wohl
lohnen, vielleicht hat Africar ja noch mehr davon.

Viele Gruesse,
  Dieter
-- 
Dieter Spaar, Germany                           spaar at mirider.augusta.de


From laforge at gnumonks.org  Tue Jul 10 23:44:41 2012
From: laforge at gnumonks.org (Harald Welte)
Date: Wed, 11 Jul 2012 01:44:41 +0200
Subject: TODAY: Jul 11, 8pm / Osmocom meeting in Berlin
Message-ID: <20120710234441.GD2490@prithivi.gnumonks.org>

Hi all!

This is the announcement for the next Osmocom Berlin meeting.

	Jul 11, 8pm @ CCC Berlin, Marienstr. 11, 10113 Berlin

There is no formal presentation scheduled for this meeting.  However,
updates will be provided on various current developments, such as

 * Progress in development of GPRS PCU
 * Status of Osmocom UMA/GAN controller development
 * Planning phase of custom calypso board
 * OsmoSDR roadmap

If you are interested to show up, feel free to do so.  There is no
registration required.  The meeting is free as in "free beer", despite
no actual free beer being around.

Updates and the blog post can be found here:
http://openbsc.osmocom.org/trac/blog/osmug-20120711

Regards,
	Harald


-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



From andrew at carrierdetect.com  Mon Jul 16 17:07:02 2012
From: andrew at carrierdetect.com (Andrew Back)
Date: Mon, 16 Jul 2012 18:07:02 +0100
Subject: nanoBTS models.
Message-ID: <CADj1OPCKzP9POY-Q1J+tSDAKyqpMwySCNprgqjoXTGsssdHQvg@mail.gmail.com>

Hello,

Am I right in thinking that a nanoBTS supports only one band and this
cannot be changed, so a 165B version would be no use in Europe?

Regards,

Andrew

-- 
Andrew Back
http://carrierdetect.com



From rp.labs at gmx.ch  Mon Jul 16 18:24:41 2012
From: rp.labs at gmx.ch (Labs)
Date: Mon, 16 Jul 2012 20:24:41 +0200
Subject: nanoBTS models.
In-Reply-To: <CADj1OPCKzP9POY-Q1J+tSDAKyqpMwySCNprgqjoXTGsssdHQvg@mail.gmail.com>
References: <CADj1OPCKzP9POY-Q1J+tSDAKyqpMwySCNprgqjoXTGsssdHQvg@mail.gmail.com>
Message-ID: <50045C69.8020809@gmx.ch>

On 16-Jul-12 19:07, Andrew Back wrote:
> Hello,
Hello Andrew,

> Am I right in thinking that a nanoBTS supports only one band and this
> cannot be changed, so a 165B version would be no use in Europe?
I would say that any version is ok if you want to play and learn using 
it with OpenBSC software.
Considering that all phones that were released in the last years are 
quad-band capable you will be fine.

Another thing is that if you use a nanoBTS on DCS1900 for example will 
be much better in Europe because you will not interfere with any 
operator. I am not sure if 850 and 1900 is even used in EU. Maybe 
somebody on the list can clarify this.

> Regards,
>
> Andrew
>

Regards,
R.




From gus at bourg.net  Mon Jul 16 18:48:29 2012
From: gus at bourg.net (Gus Bourg)
Date: Mon, 16 Jul 2012 11:48:29 -0700
Subject: nanoBTS models.
In-Reply-To: <50045C69.8020809@gmx.ch>
References: <CADj1OPCKzP9POY-Q1J+tSDAKyqpMwySCNprgqjoXTGsssdHQvg@mail.gmail.com>
	<50045C69.8020809@gmx.ch>
Message-ID: <CAKL=SEpT-8+CDqXwDgfvA1gSSYS-P594EQKHy7eZ7YozXsGnoQ@mail.gmail.com>

On Mon, Jul 16, 2012 at 11:24 AM, Labs <rp.labs at gmx.ch> wrote:

> Another thing is that if you use a nanoBTS on DCS1900 for example will be
> much better in Europe because you will not interfere with any operator. I am
> not sure if 850 and 1900 is even used in EU. Maybe somebody on the list can
> clarify this.

Part of DCS1800 (downlink) and PCS1900 (uplink) do overlap.

See: http://en.wikipedia.org/wiki/GSM_frequency_bands

Thanks,
Gus



From lists at infosecurity.ch  Mon Jul 16 18:56:19 2012
From: lists at infosecurity.ch (Fabio Pietrosanti (naif))
Date: Mon, 16 Jul 2012 20:56:19 +0200
Subject: nanoBTS models.
In-Reply-To: <CAKL=SEpT-8+CDqXwDgfvA1gSSYS-P594EQKHy7eZ7YozXsGnoQ@mail.gmail.com>
References: <CADj1OPCKzP9POY-Q1J+tSDAKyqpMwySCNprgqjoXTGsssdHQvg@mail.gmail.com>
	<50045C69.8020809@gmx.ch>
	<CAKL=SEpT-8+CDqXwDgfvA1gSSYS-P594EQKHy7eZ7YozXsGnoQ@mail.gmail.com>
Message-ID: <500463D3.9080903@infosecurity.ch>

On 7/16/12 8:48 PM, Gus Bourg wrote:
> On Mon, Jul 16, 2012 at 11:24 AM, Labs <rp.labs at gmx.ch> wrote:
> 
>> Another thing is that if you use a nanoBTS on DCS1900 for example will be
>> much better in Europe because you will not interfere with any operator. I am
>> not sure if 850 and 1900 is even used in EU. Maybe somebody on the list can
>> clarify this.
> 
> Part of DCS1800 (downlink) and PCS1900 (uplink) do overlap.
> 
> See: http://en.wikipedia.org/wiki/GSM_frequency_bands

So, it would be possible to configure a nanoBTS for uses in Europe by
only using certain ARFCN allocation, avoiding overlapping frequency with
Telco's assigned frequency?

-naif



From gus at bourg.net  Mon Jul 16 21:00:51 2012
From: gus at bourg.net (Gus Bourg)
Date: Mon, 16 Jul 2012 14:00:51 -0700
Subject: nanoBTS models.
In-Reply-To: <500463D3.9080903@infosecurity.ch>
References: <CADj1OPCKzP9POY-Q1J+tSDAKyqpMwySCNprgqjoXTGsssdHQvg@mail.gmail.com>
	<50045C69.8020809@gmx.ch>
	<CAKL=SEpT-8+CDqXwDgfvA1gSSYS-P594EQKHy7eZ7YozXsGnoQ@mail.gmail.com>
	<500463D3.9080903@infosecurity.ch>
Message-ID: <CAKL=SEq4fW8VNu464ST2N-s1DvOBG6zvxq=WtsJyqz=F6JAepA@mail.gmail.com>

On Mon, Jul 16, 2012 at 11:56 AM, Fabio Pietrosanti (naif)
<lists at infosecurity.ch> wrote:

> So, it would be possible to configure a nanoBTS for uses in Europe by
> only using certain ARFCN allocation, avoiding overlapping frequency with
> Telco's assigned frequency?
>
> -naif
>

Looks possible, but take into account that PCS1900 (downlink) also
overlaps with IMT2100 (uplink).

See: http://en.wikipedia.org/wiki/UMTS_frequency_bands

Also, just because the band might not be used for GSM applications,
doesn't mean it's not licensed for other use in your country.
Certainly the best way to be sure that you're not interfering is to
have a test license and/or run your gear in an appropriate cage.



From andrew at carrierdetect.com  Mon Jul 16 22:06:06 2012
From: andrew at carrierdetect.com (Andrew Back)
Date: Mon, 16 Jul 2012 23:06:06 +0100
Subject: nanoBTS models.
In-Reply-To: <CAKL=SEq4fW8VNu464ST2N-s1DvOBG6zvxq=WtsJyqz=F6JAepA@mail.gmail.com>
References: <CADj1OPCKzP9POY-Q1J+tSDAKyqpMwySCNprgqjoXTGsssdHQvg@mail.gmail.com>
	<50045C69.8020809@gmx.ch>
	<CAKL=SEpT-8+CDqXwDgfvA1gSSYS-P594EQKHy7eZ7YozXsGnoQ@mail.gmail.com>
	<500463D3.9080903@infosecurity.ch>
	<CAKL=SEq4fW8VNu464ST2N-s1DvOBG6zvxq=WtsJyqz=F6JAepA@mail.gmail.com>
Message-ID: <CADj1OPA8yzKGWNWLEGWFu8CuL1OxaJPO=EYMP7yVShe337Ly8Q@mail.gmail.com>

On 16 July 2012 22:00, Gus Bourg <gus at bourg.net> wrote:
> On Mon, Jul 16, 2012 at 11:56 AM, Fabio Pietrosanti (naif)
> <lists at infosecurity.ch> wrote:
>
>> So, it would be possible to configure a nanoBTS for uses in Europe by
>> only using certain ARFCN allocation, avoiding overlapping frequency with
>> Telco's assigned frequency?
>>
>> -naif
>>
>
> Looks possible, but take into account that PCS1900 (downlink) also
> overlaps with IMT2100 (uplink).
>
> See: http://en.wikipedia.org/wiki/UMTS_frequency_bands
>
> Also, just because the band might not be used for GSM applications,
> doesn't mean it's not licensed for other use in your country.
> Certainly the best way to be sure that you're not interfering is to
> have a test license and/or run your gear in an appropriate cage.

Indeed, hence my question about whether they are permanently fixed to
one band. I don't intend to radiate unless I'm licensed or the
band/use is exempt.

Thank you all for the replies.

Regards,

Andrew

-- 
Andrew Back
http://carrierdetect.com



From laforge at gnumonks.org  Sun Jul 22 11:01:27 2012
From: laforge at gnumonks.org (Harald Welte)
Date: Sun, 22 Jul 2012 13:01:27 +0200
Subject: Poll: Osmocom meeting 25th of July?
Message-ID: <20120722110127.GX7693@prithivi.gnumonks.org>

Hi all!

On Wednesday, 25th of July we would have the next Osmocom meeting
berlin.  However, neither Holger nor I will be in Berlin on that day to
host the event.  I also know that Tobias will not be in Berlin.

Nonetheless, if there are other people that want to meet up, there is no
reason to not hold it!  So I would like to get some feedback on who
would want to attend next wednesday.  If there are a couple of people,
I'll try to find somebody who can open the CCCB for you.

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



From peter at stuge.se  Sun Jul 22 15:23:36 2012
From: peter at stuge.se (Peter Stuge)
Date: Sun, 22 Jul 2012 17:23:36 +0200
Subject: Poll: Osmocom meeting 25th of July?
In-Reply-To: <20120722110127.GX7693@prithivi.gnumonks.org>
References: <20120722110127.GX7693@prithivi.gnumonks.org>
Message-ID: <20120722152336.6965.qmail@stuge.se>

Harald Welte wrote:
> if there are other people that want to meet up, there is no reason
> to not hold it!  So I would like to get some feedback on who
> would want to attend next wednesday.  If there are a couple of
> people, I'll try to find somebody who can open the CCCB for you.

I would be happy to meet with some people in CCCB for a chat.

I don't have much of an agenda to suggest though..

I would be happy to talk about what I have learned about the Nokia
MetroSite BTS, maybe show how to commission it and so on.


//Peter



From peter at stuge.se  Wed Jul 25 13:05:14 2012
From: peter at stuge.se (Peter Stuge)
Date: Wed, 25 Jul 2012 15:05:14 +0200
Subject: Poll: Osmocom meeting 25th of July?
In-Reply-To: <20120722152336.6965.qmail@stuge.se>
References: <20120722110127.GX7693@prithivi.gnumonks.org>
	<20120722152336.6965.qmail@stuge.se>
Message-ID: <20120725130514.18453.qmail@stuge.se>

Peter Stuge wrote:
> I would be happy to meet with some people in CCCB for a chat.
> 
> I don't have much of an agenda to suggest though..

I'll bring an HP 8922 handset tester tonight, and we will try to do
some testing with it.


See you there.

//Peter



From ml at mail.tsaitgaist.info  Sun Jul 22 21:35:36 2012
From: ml at mail.tsaitgaist.info (Kevin Redon)
Date: Sun, 22 Jul 2012 23:35:36 +0200
Subject: Poll: Osmocom meeting 25th of July?
In-Reply-To: <20120722110127.GX7693@prithivi.gnumonks.org>
References: <20120722110127.GX7693@prithivi.gnumonks.org>
Message-ID: <1342992841-sup-4589@dennou>

Hi,

I would be there too, and happy to discuss, but have nothing to present.

kevin

Excerpts from Harald Welte's message of Sun Jul 22 13:01:27 +0200 2012:
> Hi all!
> 
> On Wednesday, 25th of July we would have the next Osmocom meeting
> berlin.  However, neither Holger nor I will be in Berlin on that day to
> host the event.  I also know that Tobias will not be in Berlin.
> 
> Nonetheless, if there are other people that want to meet up, there is no
> reason to not hold it!  So I would like to get some feedback on who
> would want to attend next wednesday.  If there are a couple of people,
> I'll try to find somebody who can open the CCCB for you.
> 
> Regards,
>     Harald



From altaf329 at gmail.com  Mon Jul 23 07:40:45 2012
From: altaf329 at gmail.com (altaf sk)
Date: Mon, 23 Jul 2012 09:40:45 +0200
Subject: Poll: Osmocom meeting 25th of July?
In-Reply-To: <1342992841-sup-4589@dennou>
References: <20120722110127.GX7693@prithivi.gnumonks.org>
	<1342992841-sup-4589@dennou>
Message-ID: <CAGxkagbCh_a4L5s9GfcMYpYbmkDs0dFrTkso3mRcr6G6gK6K1A@mail.gmail.com>

Hello

I would like to attend the meeting and share some ideas.

Can some one provide me the Rainbow Tables at the meeting. I have a 2TB
Hard disk.

Thank you

Altaf

On Sun, Jul 22, 2012 at 11:35 PM, Kevin Redon <ml at mail.tsaitgaist.info>wrote:

> Hi,
>
> I would be there too, and happy to discuss, but have nothing to present.
>
> kevin
>
> Excerpts from Harald Welte's message of Sun Jul 22 13:01:27 +0200 2012:
> > Hi all!
> >
> > On Wednesday, 25th of July we would have the next Osmocom meeting
> > berlin.  However, neither Holger nor I will be in Berlin on that day to
> > host the event.  I also know that Tobias will not be in Berlin.
> >
> > Nonetheless, if there are other people that want to meet up, there is no
> > reason to not hold it!  So I would like to get some feedback on who
> > would want to attend next wednesday.  If there are a couple of people,
> > I'll try to find somebody who can open the CCCB for you.
> >
> > Regards,
> >     Harald
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20120723/3f12a790/attachment.htm>

From 246tnt at gmail.com  Mon Jul 23 08:47:37 2012
From: 246tnt at gmail.com (Sylvain Munaut)
Date: Mon, 23 Jul 2012 10:47:37 +0200
Subject: Poll: Osmocom meeting 25th of July?
In-Reply-To: <CAGxkagbCh_a4L5s9GfcMYpYbmkDs0dFrTkso3mRcr6G6gK6K1A@mail.gmail.com>
References: <20120722110127.GX7693@prithivi.gnumonks.org>
	<1342992841-sup-4589@dennou>
	<CAGxkagbCh_a4L5s9GfcMYpYbmkDs0dFrTkso3mRcr6G6gK6K1A@mail.gmail.com>
Message-ID: <CAHL+j0-f98VFekfxHOPLdMUnWkH9sqkJKWCsfcyBtFBJzTs-Bg@mail.gmail.com>

> Can some one provide me the Rainbow Tables at the meeting. I have a 2TB Hard
> disk.

Assuming a 40 Mo/s transfer rate over USB disk (and that's
optimistic), you're looking at 11h to make the copy ...

Cheers,

    Sylvain



From altaf329 at gmail.com  Mon Jul 23 09:19:35 2012
From: altaf329 at gmail.com (altaf sk)
Date: Mon, 23 Jul 2012 11:19:35 +0200
Subject: Poll: Osmocom meeting 25th of July?
In-Reply-To: <CAHL+j0-f98VFekfxHOPLdMUnWkH9sqkJKWCsfcyBtFBJzTs-Bg@mail.gmail.com>
References: <20120722110127.GX7693@prithivi.gnumonks.org>
	<1342992841-sup-4589@dennou>
	<CAGxkagbCh_a4L5s9GfcMYpYbmkDs0dFrTkso3mRcr6G6gK6K1A@mail.gmail.com>
	<CAHL+j0-f98VFekfxHOPLdMUnWkH9sqkJKWCsfcyBtFBJzTs-Bg@mail.gmail.com>
Message-ID: <CAGxkagY0YCqPCcxCW2_OOymq5Q9xuBBj5x87TNyT6Wq20Tm-cg@mail.gmail.com>

Hello.

I can lend the hard disk to whoever provides me the tables and I can
collect it later.

Thanks

On Mon, Jul 23, 2012 at 10:47 AM, Sylvain Munaut <246tnt at gmail.com> wrote:

> > Can some one provide me the Rainbow Tables at the meeting. I have a 2TB
> Hard
> > disk.
>
> Assuming a 40 Mo/s transfer rate over USB disk (and that's
> optimistic), you're looking at 11h to make the copy ...
>
> Cheers,
>
>     Sylvain
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20120723/e0e715a1/attachment.htm>

From andrew at carrierdetect.com  Sat Jul 28 10:12:46 2012
From: andrew at carrierdetect.com (Andrew Back)
Date: Sat, 28 Jul 2012 11:12:46 +0100
Subject: GN A-Bis test sets on eBay.
Message-ID: <CADj1OPBqFaK0zveEQzwkUy1AftJJj23-A3xUzstwFbsLvOWziA@mail.gmail.com>

Hello,

Interesting looking A-Bis test equipment on eBay right now:

  http://www.ebay.co.uk/itm/GN-EGM-Nettest-35-GSM-A-Bis-Test-Meter-Elmi-EGM35-/380452813797

Appears to be PCM only though and I imagine of limited usefulness.

Best,

Andrew

-- 
Andrew Back
http://carrierdetect.com