two minor bugs in libosmo-abis

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

jolly andreas at eversberg.eu
Tue Jan 17 16:28:00 UTC 2012


hi,

i fixed two obvious bugs in libosmo-abis. the first fix uses correct reference for mISDN interface number, the other handles variable frame lengths. both are tested. if nobody minds, i like to commit them.

regards,

andreas



Fixed wrong reference while opening mISDN socket

diff --git a/src/input/misdn.c b/src/input/misdn.c
index 2ed152e..5fdd847 100644
--- a/src/input/misdn.c
+++ b/src/input/misdn.c
@@ -484,7 +484,7 @@ static int mi_e1_setup(struct e1inp_line *line, int release_l2)
 			}
 			memset(&addr, 0, sizeof(addr));
 			addr.family = AF_ISDN;
-			addr.dev = line->num;
+			addr.dev = line->port_nr;
 			addr.channel = 0;
 			addr.sapi = 0;
 			addr.tei = GROUP_TEI;


Fixed TRAU frame handling of packet lengths that are not a multiple of 4

diff --git a/src/subchan_demux.c b/src/subchan_demux.c
index 41fe1d2..8613c17 100644
--- a/src/subchan_demux.c
+++ b/src/subchan_demux.c
@@ -102,10 +102,6 @@ int subch_demux_in(struct subch_demux *dmx, uint8_t *data, int len)
 {
 	int i, c;
 
-	/* we avoid partially filled bytes in outbuf */
-	if (len % 4)
-		return -EINVAL;
-
 	for (i = 0; i < len; i++) {
 		uint8_t inbyte = data[i];
 





More information about the OpenBSC mailing list