[PATCH 05/13] tests: e1inp_ipa_bts_test: fix compilation warnings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

pablo at gnumonks.org pablo at gnumonks.org
Thu Aug 23 22:44:54 UTC 2012


From: Pablo Neira Ayuso <pablo at gnumonks.org>

  CC     e1inp_ipa_bts_test.o
e1inp_ipa_bts_test.c: In function ‘sign_link_up’:
e1inp_ipa_bts_test.c:47:8: warning: variable ‘dst’ set but not used [-Wunused-but-set-variable]
e1inp_ipa_bts_test.c: In function ‘test_bts_gsm_12_21_cb’:
e1inp_ipa_bts_test.c:211:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
  CCLD   e1inp_ipa_bts_test
---
 tests/e1inp_ipa_bts_test.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/e1inp_ipa_bts_test.c b/tests/e1inp_ipa_bts_test.c
index 3549661..bf46e9e 100644
--- a/tests/e1inp_ipa_bts_test.c
+++ b/tests/e1inp_ipa_bts_test.c
@@ -44,7 +44,6 @@ static struct e1inp_sign_link *
 sign_link_up(void *unit, struct e1inp_line *line, enum e1inp_sign_type type)
 {
 	struct e1inp_sign_link *sign_link = NULL;
-	void *dst = NULL;
 
 	switch(type) {
 	case E1INP_SIGN_OML:
@@ -58,7 +57,6 @@ sign_link_up(void *unit, struct e1inp_line *line, enum e1inp_sign_type type)
 			LOGP(DBTSTEST, LOGL_ERROR,
 				"cannot create OML sign link\n");
 		}
-		dst = oml_sign_link;
 		if (oml_sign_link) {
 			unsigned int event_type = 0;
 
@@ -84,7 +82,6 @@ sign_link_up(void *unit, struct e1inp_line *line, enum e1inp_sign_type type)
 			LOGP(DBTSTEST, LOGL_ERROR,
 				"cannot create RSL sign link\n");
 		}
-		dst = rsl_sign_link;
 		break;
 	default:
 		return NULL;
@@ -221,6 +218,10 @@ static int test_bts_gsm_12_21_cb(struct osmo_fd *ofd, unsigned int what)
 					 unit->bts_id,
 					 unit->trx_id,
 					 0, NULL, 0);
+		if (ret < 0) {
+			LOGP(DBTSTEST, LOGL_ERROR, "cannot send SW ACT REQ\n");
+			break;
+		}
 		bts_state = BTS_TEST_OML_WAIT_SW_ACT_ACK;
 		break;
 	case BTS_TEST_OML_WAIT_SW_ACT_ACK:
-- 
1.7.10.4





More information about the OpenBSC mailing list