[PATCH 01/11] ipa: fix missing set of write_cb for IPA client connection

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Thu Aug 23 17:17:32 UTC 2012


On Thu, Aug 23, 2012 at 09:03:21AM +0200, Holger Hans Peter Freyther wrote:
> On Wed, Aug 22, 2012 at 05:04:43PM +0200, pablo at gnumonks.org wrote:
> > From: Pablo Neira Ayuso <pablo at gnumonks.org>
> 
> Hi,
> 
> > 
> > Now the BTS and BSC tests work again.
> 
> could you look into integrating your test with the GNU autotest testsuite
> we use in libosmocore/libosmo-sccp/openbsc? This way we would catch this
> issue at build time.

I will. Would you be OK if I do that in some follow-up patchset?

> >  	if (write_cb == NULL)
> >  		ipa_link->write_cb = ipa_client_write_default_cb;
> > +	else
> > +		ipa_link->write_cb = write_cb;
> > +
> 
> this means that only the tests (and no real application) set a custom
> write_cb? is there another way to test?

It's ipaccess driver which is setting its own write_cb to integrate
itself with the e1inp queue of messages that you get via e1inp_tx_ts.




More information about the OpenBSC mailing list