bug in A-bis OML wireshark dissector

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Mon Sep 19 00:56:12 UTC 2011


Hi!

While submitting the A-bis OML wireshark dissector I noticed one bug
in it that results in bogus message labeling.

The following patch should be applied to osmocom/wireshark.git tree.

P.S: I have submitted a patch to wireshark bugzilla that includes this
bugfix.
-------------- next part --------------
diff --git a/epan/dissectors/packet-gsm_abis_oml.c b/epan/dissectors/packet-gsm_abis_oml.c
index 0066933..ee97fad 100644
--- a/epan/dissectors/packet-gsm_abis_oml.c
+++ b/epan/dissectors/packet-gsm_abis_oml.c
@@ -1184,6 +1184,7 @@ _match_oml_fom_msgtype(const guint32 val, const value_string_ext *vs)
 		ret = match_strval_idx(val, _oml_fom_msgtype_vals, &idx);
 		if (!ret)
 			return NULL;
+		return &(_oml_fom_msgtype_vals[idx]);
 	}
 	return &(vs->_vs_p[idx]);
 }
@@ -1198,6 +1199,7 @@ _match_oml_fom_attr(const guint32 val, const value_string_ext *vs)
 		ret = match_strval_idx(val, _oml_fom_attr_vals, &idx);
 		if (!ret)
 			return NULL;
+		return &(_oml_fom_attr_vals[idx]);
 	}
 	return &(vs->_vs_p[idx]);
 }


More information about the OpenBSC mailing list