[PATCH 0/5] pablo/ctrl-updates related patches

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Daniel Willmann daniel at totalueberwachung.de
Thu Sep 15 14:04:48 UTC 2011


Hello Pablo,

attached are patches against the current pablo/ctrl-updates branch that
fix the compile issues. It needs the closed callback in libosmo-abis to
work. As long as the bsc_msc_connection is still using write_queues I
have added the old ctrl_cmd_send function again (under a different name)
So we can still send commands over that connection.
I've tested the communication/timeout/closed_cb handling and nothing
problematic showed up.

Having two send commands is unfortunate, but I guess it's okay for the
time being. I'm guessing that the other connections will be switching to
libosmo-abis as well in the foreseeable future and then this issue will
resolve itself.

Feel free to squash the patches as you see fit in order to get them
merged.

Regards,
Daniel Willmann (5):
  libctrl: Catch up with API change for ipa_server_conn_create
  nat: Use libosmo-abis infrastructure in the pending entries
  libctrl: Add a new function to send commands through an osmo_wqueue
  osmo-bsc: Use ctrl_cmd_send_wqueue to send cmds over the nat-bsc link
  nat: Use ctrl_cmd_send_wqueue to send cmds over the nat-bsc link

 openbsc/include/openbsc/bsc_nat.h     |    2 +-
 openbsc/include/openbsc/control_cmd.h |    1 +
 openbsc/src/libctrl/control_if.c      |   24 +++++++++++++++++++++++-
 openbsc/src/osmo-bsc/osmo_bsc_msc.c   |    4 ++--
 openbsc/src/osmo-bsc_nat/bsc_nat.c    |   19 ++++++++++---------
 5 files changed, 37 insertions(+), 13 deletions(-)

-- 
1.7.6.1





More information about the OpenBSC mailing list