[PATCH 3/3] ctrl: do not disable nagle algorithm until we fully support segmentation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

pablo at gnumonks.org pablo at gnumonks.org
Fri Sep 9 01:05:29 UTC 2011


From: Pablo Neira Ayuso <pablo at gnumonks.org>

We shouldn't disable nagle, we have to finish TCP segmentation
support appropriately first.
---
 openbsc/src/libctrl/control_if.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/openbsc/src/libctrl/control_if.c b/openbsc/src/libctrl/control_if.c
index 58476ec..7e2ae16 100644
--- a/openbsc/src/libctrl/control_if.c
+++ b/openbsc/src/libctrl/control_if.c
@@ -241,15 +241,8 @@ err:
 
 static int ctrl_accept_cb(struct ipa_server_link *ipa_link, int fd)
 {
-	int ret, on = 1;
 	struct ipa_server_conn *ipa_peer_link;
 
-	ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &on, sizeof(on));
-	if (ret != 0) {
-		LOGP(DNAT, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", strerror(errno));
-		close(fd);
-		return ret;
-	}
 	ipa_peer_link = ipa_server_conn_create(tall_bsc_ctx, ipa_link, fd,
 						handle_control_read,
 						ipa_link->data);
-- 
1.7.2.5





More information about the OpenBSC mailing list