[PATCH 3/7] tests: remove reference to internal headers in ipa_proxy_test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Mon Sep 12 08:09:52 UTC 2011


Hi Holger,

On Sun, Sep 11, 2011 at 11:42:46PM +0200, Holger Hans Peter Freyther wrote:
> On 09/09/2011 02:36 AM, pablo at gnumonks.org wrote:
> > From: Pablo Neira Ayuso <pablo at gnumonks.org>
> > 
> > This example has to compile out of the tree, including internal.h
> > is not required and using PACKAGE_VERSION here, which is internal
> > to the library, does not seem to me like a good idea.
> 
> why should it compile out of tree? Ideally it would be hooked into make check
> and use GNU autotest (to match test output with expected results).

Although they are integrated in the build system, they are examples.
Thus, someone may take of those files and use part of it to integrate
it into the own application. That's why I think it's a good idea that
they can be compiled out of tree.

> In case we
> want to have it as an example, I think we could move it into a/the
> documentation folder and somehow include it in doxygen documentation?

Probably test is not a good name for the folder, we could rename it to
utils/ or examples/.

I can add some note in the documentation to tell about these examples.

I'll add these to my "to do" list.




More information about the OpenBSC mailing list