fix missing all logging command option

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Thu May 19 00:18:33 UTC 2011


On 19/05/11 01:10, Holger Freyther wrote:
> On 05/19/2011 01:04 AM, Pablo Neira Ayuso wrote:
>> Hi Holger,
>>
>> Thanks for fixing this, I missed it:
>>
>> http://cgit.osmocom.org/cgit/libosmocore/commit/?id=952a18ed19f531b82e26108f8c46ef225fddef43
>>
>> However, this fix is incomplete:
> 
> Hi,
> 
> thanks for the review (*blushing*). I think we should rely more on talloc
> here, e.g. use the various _append functions provided by talloc. This way we
> avoid having such issues again.

Yes, it's easy to make this sort of mistakes, that code looks better
than before I patched it but still a bit sloppy. I'll see if I find some
spare time to use your suggestion to improve it.




More information about the OpenBSC mailing list