[PATCH 1/4] abis: skip e1_input nesting if empty

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

pablo at gnumonks.org pablo at gnumonks.org
Sat May 14 11:57:48 UTC 2011


From: Pablo Neira Ayuso <pablo at gnumonks.org>

With this patch, we don't include e1_input if it's empty

[...]
    timeslot 7
     phys_chan_config TCH/F
     hopping enabled 0
e1_input <----------------- empty, it should not show up.
msc
[...]
---
 openbsc/src/libabis/e1_input_vty.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/openbsc/src/libabis/e1_input_vty.c b/openbsc/src/libabis/e1_input_vty.c
index 7dbf17a..b211e81 100644
--- a/openbsc/src/libabis/e1_input_vty.c
+++ b/openbsc/src/libabis/e1_input_vty.c
@@ -76,6 +76,9 @@ static int e1inp_config_write(struct vty *vty)
 {
 	struct e1inp_line *line;
 
+	if (llist_empty(&e1inp_line_list))
+		return CMD_SUCCESS;
+
 	vty_out(vty, "e1_input%s", VTY_NEWLINE);
 
 	llist_for_each_entry(line, &e1inp_line_list, list) {
-- 
1.7.2.3





More information about the OpenBSC mailing list