[PATCH] wireshark: gsm-abis-oml: convert C99 structure initialization to ANSI C

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Sun Mar 6 13:52:20 UTC 2011


On 06/03/11 14:45, Holger Hans Peter Freyther wrote:
> On 03/06/2011 02:20 PM, Pablo Neira Ayuso wrote:
> 
>>
>> Still, I think that I've got issue with a warning that spots a dissector
>> bug.
> 
> Yes, I think this was there before as well and on top of this I have never
> tried the randpkt to fuzz the dissector as mentioned in doc/README.developer.

I didn't know about this, I'll check it.

> From a quick look at GSM 12.21, a trace I have, it looks like NM_ATT_SW_DESCR
> is not in the TLV table and this explains why we end up here. It might be a
> good opportunity to see what else we are missing.

I'll investigate this, thanks for the clue!

>>
>> BTW, the output of the patch is in git format, so I think that you can
>> apply it with git am. It's the inner patch (which is contained inside
>> this patch) that it's in svn format 8-).
> 
> Yes, I am talking about git am -3 for the inner part as this (wireshark svn)
> is the place where having a three way merge is going to be the most useful
> thing to do. :)

Oh, I see, I didn't get it, sorry!




More information about the OpenBSC mailing list