This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgHi pablo,
On Thu, Mar 03, 2011 at 07:01:49PM +0100, Pablo Neira Ayuso wrote:
> It converts the C99 structure initialization which is not accepted by
> the wireshark developers (Harald told me that they need it to compile
> with non-gcc compilers which don't always support C99).
It's a very elegant solution to do the initialization at startup time,
I like that (and didn't think of it any earlier...).
Let's hope the wireshark guys think similar!
> I have tested it here with four pcap files that Harald passed to me. It
> works fine.
>
> BTW, *with* and *without* this patch, wireshark with dissector spots
> warnings like:
>
> 18:14:15 Warn Dissector bug, protocol A-bis OML, in packet 13:
> packet-gsm_abis_oml.c:940: failed assertion "DISSECTOR_ASSERT_NOT_REACHED"
>
> It seems that some TLVs that appear in the body of packets are unknown.
> I'll debug which are the complaining tags and get back you.
Did you enable the 'use ip.access nanoBTS' flag in the protocol preferences
for the OML dissector? If you don't it will try to use the Siemens definitions
on an ip.access protocol trace (which will break).
I will apply your patch right now...
Regards,
Harald.
--
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)