[PATCH] wireshark: gsm-abis-oml: convert C99 structure initialization to ANSI C

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Thu Mar 3 18:01:49 UTC 2011


Hi!

This patch applies on top of the wireshark/0001-abis_oml.patch.

It converts the C99 structure initialization which is not accepted by
the wireshark developers (Harald told me that they need it to compile
with non-gcc compilers which don't always support C99).

I have tested it here with four pcap files that Harald passed to me. It
works fine.

BTW, *with* and *without* this patch, wireshark with dissector spots
warnings like:

18:14:15          Warn Dissector bug, protocol A-bis OML, in packet 13:
packet-gsm_abis_oml.c:940: failed assertion "DISSECTOR_ASSERT_NOT_REACHED"

It seems that some TLVs that appear in the body of packets are unknown.
I'll debug which are the complaining tags and get back you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-01-ansic89-struct-initialization.patch
Type: text/x-patch
Size: 18930 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20110303/0f579da5/attachment.bin>


More information about the OpenBSC mailing list