This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Dennis Wehrle openbsc at wehrle.itHi Holger On 24.07.2011 20:20, Holger Hans Peter Freyther wrote: > > Hi Dennis, > > I pushed zecke/sms-fixes-by-dennis-wehrle to libosmocore, do you agree with > the change? Sure, i agree with your changes. > I have moved the VTY change to a new patch (if you want to I can > use you as author), I think, it's not necessary :) > I left the 'normal' _decode message like it was and added > a new method to it, I also had some cosmetic changes (formation). I would also > like to see a rewording of the commit message. I think there are some typos in my commit message. For instance, in the first sentence, i think it should be 'were' instead of 'where'. On 24.07.2011 20:30, Holger Hans Peter Freyther wrote: > Hi Dennis, > > do you think you could split the work into multiple patches? E.g. > > 1.) Fix the truncation of the message when sent from the VTY > 2.) Move from id to number in the SMS Table (also bump the db version) > 3.) Implement multipart SMS? > > I will try to start with 1st, it would be very kind of you could work on the > other parts. Sure, i can split it up. My understanding is that the patch for task 2.) depends on task 1.) and the patch for task 3.) depends on task 2.). (create a patch between the commits) Right? On 24.07.2011 22:18, Holger Hans Peter Freyther wrote: > On 07/24/2011 08:30 PM, Holger Hans Peter Freyther wrote: > >> >> I will try to start with 1st, it would be very kind of you could work on the >> other parts. > > E.g. I think this will fix the truncation issue from the VTY. Ok, i can work on the missing two parts. I will also have a look at your patch. Best Regards Dennis