[PATCH] input: fix multiple BTS attached to single line scenario

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Tue Aug 30 15:25:52 UTC 2011


Hi Pablo,

this is unfortunately not what I would like to see.  The flag should be
hidden in the ipaccess.c / hsl.c driver, and it should not be globally
visible.

I think it's a bid odd to handle a special case like this in the generic
code / data structure.

By definition, the driver has to cope with the fact that the
line_update() function is called multiple times.  That's what the name
also indicates.  If a driver wants to do something different, it has to
solve the problem on the driver side.

Each driver can allocate its own structure and tie it to
line->driver_data, like the misdn.c driver is doing it.  In there it can
handle local state like 'has this line been initialized before and do I
thus want to skip another round of initialization'.

Regards,
	Harald
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the OpenBSC mailing list