This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgHi Pablo,
On Tue, Aug 30, 2011 at 12:44:38PM +0200, Pablo Neira Ayuso wrote:
> > > I introduced refcounting in the ->line_update() update path in
> > > libosmo-abis, which calls the setup function only once (I needed this
> > > to avoid binding the A-bis over IP socket twice).
> >
> > I see. But I believe this is the wrong path to "solve" the problem.
> > The function is called "update" since it is supposed to be called
> > multiple times, every time something has changed about the line (e.g.
> > timeslot configuration).
>
> I can recover the ->start() callback that would be called once for
> A-bis over IP drivers, so I don't need to use line_update() for this.
> Or add some flag to the lines, so we can know which ones can be
> updated several times or not.
I think having one 'update' callback is fine, no need for an extra
'start' callback.
The abis/ip line driver simlpy would have to use some privat per-line
data structure to keep the state if it has already been 'updated' once
and skip further update calls.
Regards,
Harald
> > With multiple BTS attached to a signle line, there is no other way but
> > to call the function multiple times. It has to be written with that in
> > mind.
>
> I missed the multiple-BTS-to-single-line setup, I'll send you a patch
> to fix this situation.
no problem, looking forward to your patch.
--
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)