A problem in OpenBSC, sccp.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Wenbin Wu wenbin87 at gmail.com
Thu Oct 21 08:23:01 UTC 2010


Hello,

I have a problem in sccp.c.

537--543
    udt->type = SCCP_MSG_TYPE_UDT;
    udt->proto_class = class;
    udt->variable_called = 3;
    udt->variable_calling = 5 + out->gti_len;
    if(out->use_poi) udt->variable_calling += 2;
    udt->variable_data = 7 + out->gti_len + in->gti_len;
    if(in->use_poi) udt->variable_calling += 2;

I add these two 'if' lines in the code. I'm not sure if it is right.
In source code, before it calls 'create_sccp_addr', it sets the length only
using gti_len. But in 'create_sccp_addr', if I use poi, the length should be
add 2.

Am I right?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20101021/6f3084b3/attachment.htm>


More information about the OpenBSC mailing list