This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Nico Golde openbsc at lists.gnumonks.orgHi, * Holger Freyther <zecke at selfish.org> [2010-07-08 20:04]: > On 07/08/2010 11:56 PM, Nico Golde wrote: > > I adjusted the copyright stanza in these files but I'm not > > completely sure if this is appropriate or not, so feel free > > to remove, I won't be offended :) > > The rule of thumb I heard is that anything above four lines > of code is copyrightable, so your addition is totally fine! Ok. > I do have two nitpicks though. We do not indent the case labels > inside a switch statement Fixed, attached. > and the other is more important to me, > and might ask you to write a decoder, could you please update > the encoding/decoding and add the string that could not be > decoded by the current code? I felt this was coming :) I didn't write the decoder yet as it was quite time consuming already to go through the encoding process and I personally didn't need the decoding yet. But I agree, of course a decoder that fits the encoder is necessary (even though what could be properly decoded before also can be properly decoded now, no change for this). And I'm also willing to write it as soon as I have more time. As a string my example was '@' which should be encoded as 00 (1 byte hex) but is encoded as 40 instead by the current code. Cheers Nico