[PATCH 3/4] tlv_parser: Split the tlv into 'parse loop' and 'parse single value'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Mon Oct 26 19:21:31 UTC 2009


Thanks, applied.

For the future, please don't mix two things in one patch.  In addition to
splitting the function, you have also changed the variables, i.e. no longer
using 'pos' but the offset.  That should have been a separate patch and made
review much easier.

Regards,
-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the OpenBSC mailing list