[PATCH 3/4] [gprs] Fix hardcoded IP addresses in GPRS UDP communication

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Sylvain Munaut 246tnt at gmail.com
Fri Nov 20 14:11:33 UTC 2009


Harald Welte wrote:
>> Note, there is still an ugly hack: We send packets to the
>> first BTS we find and not the "right" one, mostly because
>> I had no idea how to find the right one ...
>
> ok, I think we should wait for a proper solution, rather than replacing one
> hack with another one.

Yes, I hesitated posting the patch, but the advantage of this hack was
that it is automatic :)


>> +		/* FIXME: Just take the first ip.access bts we find */
>> +	llist_for_each_entry(bts, &e1h->gsmnet->bts_list, list) {
>> +		if (!is_ipaccess_bts(bts))
>> +			continue;
>> +		break;
>
> msg->trx will be set, so you can simply dereference msg->trx->bts to get to the
> bts to which this should be sent.

That was my first thought. But it's not set (or at least not always),
leading to a seg fault when I tried that. For examples packets send
with gprs_ns_tx_simple don't have it set. And I didn't see any clean way
to get it from where those were generated.


	Sylvain




More information about the OpenBSC mailing list