[PATCH] Implement TP-VPF-ENHANCED

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Steffen 'stefreak' Neubauer stefreak at stefreak.de
Wed Nov 18 17:29:07 UTC 2009


On Wed, 18 Nov 2009 09:43:48 +0100
Holger Freyther <zecke at selfish.org> wrote:

> Yes, I would put all these into static methods... the compiler will
> inline them for you. The problem with this amount of gotos is it is
> really hard to understand which ways you are jumping. E.g. within
> "enhanced" you will do a backward jump. The problem with that it is
> very hard to make sure that your jumping will end... if/else if and
> function calls are much easier to read.

Okay, Thank You for your comments!
The new patch is attached.

Again, If that's easier you can simply merge my tp-vp branch on github.

Thank You and Greetings,
Steffen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 7374 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20091118/4c377084/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20091118/4c377084/attachment-0001.bin>


More information about the OpenBSC mailing list