[PATCH] implemented GSM340_TP_VPF_ABSOLUTE

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Steffen 'stefreak' Neubauer stefreak at stefreak.de
Sun Nov 8 13:08:56 UTC 2009


Hello Harald,

On Sun, 8 Nov 2009 14:39:02 +0900
Harald Welte <laforge at gnumonks.org> wrote:

> thanks for your patch, it is most welcome.  Sorry for not providing
> feedback earlier.   Please see my comments below:

no problem, thank you for your comment! :)

> please declare the variables (expires/now) at the beginning of the
> section, e.g. the case statement or even the top of the function.

They were declared at the beginning of the case statement, aren't they?
But now they are declared on top of the function.

> we might want to have some kind of treatment (or at least an error
> message) if the input BCD nibbles exceed the 0...9 range.

Okay, now it sends a debug message.

> mh. We are no wending GMT but no timezone information, which I'm not
> quite sure if it is better than we did before.  A proper solution
> would be to use the signed value of tm->tm_gmtoff/(60*15);

Before it sent the local time but with the timezone information
"GMT/UTC" (offset=0). But now it sends the local timezone and the local
timezone information.

> is this year '60' specified anywhere in the GSM spec, or did you just
> introduce it yourself?  In the latter case, I would rather use
> something like 80, since GSM was not specified before the eighties.

No, the spec didn't specify this anywhere, even not in the newest
version of the document. You're right, 80 is a better value. Fixed it ;)

> Thanks again,
> 	Harald

I have to thank you!

The new patch is attached :)

Greetings,
Steffen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 2644 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20091108/662417ad/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20091108/662417ad/attachment-0001.bin>


More information about the OpenBSC mailing list