patch: 30

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther zecke at selfish.org
Tue Jun 9 06:49:19 UTC 2009


On Tuesday 09 June 2009 10:14:31 Andreas.Eversberg wrote:
> my subsequent patches are dependant on the patches by holger from may 5th.
> for personal testing and for information, i packed them together. i tested
> them and they work well.

Cool. I will take this as an ack to land them... There is one change you made 
and it looks like this one:

 
@@ -941,7 +956,6 @@
        if (!subscr) {
                DEBUGP(DRR, "<- Can't find any subscriber for this ID\n");
                /* FIXME: request id? close channel? */
-               return -EINVAL;
        }
        DEBUGP(DRR, "<- Channel was requested by %s\n",
                subscr->name ? subscr->name : subscr->imsi);

We have two cases in there that will return -EINVAL. Maybe we should replace 
both with an error signal?

	z.




More information about the OpenBSC mailing list