patch 24: output

[Holger Freyther]

On Monday 01 June 2009 19:33:44 Andreas.Eversberg wrote:
> Some debug outputs now correctly use end-of-line characters.

Mostly applied:

the moving of subscr = subcr_get_by_tmsi didn't match the description and I 
wonder what is the reasoning behind it. For the other debug statements, for 
some new ones I added more than the "\n" but with the below ones I don't see
what value they add. The mi_type is printed a couple of line earlier and a 
simple log that the line of the case was hit didn't look useful to me. Do you 
agree/disagree?

thanks for the patch and looking forward for your comments

	z.


diff --git a/src/gsm_04_08.c b/src/gsm_04_08.c
index d585aae..9a2a00a 100644
--- a/src/gsm_04_08.c
+++ b/src/gsm_04_08.c
@@ -797,9 +797,9 @@ static int gsm48_rx_mm_serv_req(struct msgb *msg)
        }
 
        mi_to_string(mi_string, sizeof(mi_string), mi, mi_len);
-       subscr = subscr_get_by_tmsi(mi_string);
        DEBUGPC(DMM, "serv_type=0x%02x mi_type=0x%02x M(%s)\n",
                req->cm_service_type, mi_type, mi_string);
+       subscr = subscr_get_by_tmsi(mi_string);
 
        /* FIXME: if we don't know the TMSI, inquire abit IMSI and allocate 
new TMSI */
        if (!subscr)
@@ -831,9 +831,11 @@ static int gsm48_rx_mm_imsi_detach_ind(struct msgb *msg)
 
        switch (mi_type) {
        case GSM_MI_TYPE_TMSI:
+               DEBUGPC(DMM, "\n");
                subscr = subscr_get_by_tmsi(mi_string);
                break;
        case GSM_MI_TYPE_IMSI:
+               DEBUGPC(DMM, "\n");
                subscr = subscr_get_by_imsi(mi_string);
                break;
        case GSM_MI_TYPE_IMEI: