MEAS REP inverted logic (was Re: AW: patches again)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Sun Jul 5 02:08:20 UTC 2009


Hi Dieter,

On Tue, Jun 30, 2009 at 09:51:20AM +0200, Dieter Spaar wrote:
 
> I noticed one minor problem, its the meaning of the MEAS-VALID
> flag. The spec says that "0" means "valid" and "1" is "not valid".
> 
> So
> 
>   if (!(meas_rep.flags & MEAS_REP_F_VALID))
> 
> should be changed or the parsing of the measurement result where this
> flag is set.

thanks.  Rarther than this, I have changed it in parse_meas_rep, i.e. set
MEAS_REP_F_VALID is set if the bit is 0.

It's not yet in the public git repository yet, but in my local tree.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)




More information about the OpenBSC mailing list