This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgOn Mon, Jun 29, 2009 at 06:44:15PM +0200, Holger Freyther wrote:
> On Sunday 28 June 2009 18:47:31 Andreas.Eversberg wrote:
> > patch 39: the location update process did not work, if mobile station
> > uses tmsi when comming from a different network. in this case the
> > reject-timer must also be started, and we wait for imsi identity
> > response. in case we can't find the subscriber or if we have an
> > unimplemented location update, we release location update process and
> > send a reject.
>
> Sorry, to me it seems the patch is doing something else...
>
> 1.)
> if (!subscr) {
> DEBUGPC(DRR, "<- Can't find any subscriber for this ID\n");
> /* FIXME: request id? close channel? */
> + release_loc_updating_req(lchan);
> + gsm0408_loc_upd_rej(lchan, reject_cause);
> return -EINVAL;
> }
>
> I think we can just move the schedule_reject from two lines below the if to
> the top. What do you think?
I have just implemented this part of the patch and committed it.
--
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)