This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://firstname.lastname@example.org/.pespin gerrit-no-reply at lists.osmocom.org
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/25649 ) Change subject: VTY: Don't display 'PDP Address: invalid' for IPv4v6 ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/25649/1/src/sgsn/sgsn_vty.c File src/sgsn/sgsn_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/25649/1/src/sgsn/sgsn_vty.c@164 PS1, Line 164: strcpy(str, "IPv4 "); > I assume what you don't want here are the unused calls to strcpy/inet_ntop. […] Hmm I thought I already explained that in a previous comment but I don't see it here, maybe I erased it without noticing. Anyway, here it is: I don't want either to spend twice the amount of static memory for no good reason. Hence why the buffer can be shared, there's no real need to have 2 buffers. So basically you leave the "str" buffer as it was before, and you simply use "str" everywhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/25649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id36b7520677e4a0af40d05dc503b26d1b0b74a26 Gerrit-Change-Number: 25649 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 30 Sep 2021 18:07:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: keith <keith at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210930/c5fd16ec/attachment.htm>