Change in osmo-sgsn[master]: VTY: Don't display 'PDP Address: invalid' for IPv4v6

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Thu Sep 30 17:32:37 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/25649 )

Change subject: VTY: Don't display 'PDP Address: invalid' for IPv4v6
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-sgsn/+/25649/1/src/sgsn/sgsn_vty.c 
File src/sgsn/sgsn_vty.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/25649/1/src/sgsn/sgsn_vty.c@164 
PS1, Line 164: 			strcpy(str, "IPv4 ");
> if (return_ipv6) { […]
I assume what you don't want here are the unused calls to strcpy/inet_ntop.
I'm doing it without the else, I think it's OK.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/25649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Id36b7520677e4a0af40d05dc503b26d1b0b74a26
Gerrit-Change-Number: 25649
Gerrit-PatchSet: 3
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Sep 2021 17:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210930/1840125b/attachment.htm>


More information about the gerrit-log mailing list