Change in osmo-bts[master]: fix handle_ms_meas_report(): properly count measurement reports

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Sep 30 11:12:12 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/25651 )


Change subject: fix handle_ms_meas_report(): properly count measurement reports
......................................................................

fix handle_ms_meas_report(): properly count measurement reports

Each RSL MEASurement RESult message contains a Measurement Number
IE, which is basically a monolithically increasing number.  We
shall not increase this counter if for whatever reason the report
has not been sent to the BSC.

Change-Id: I441adb4b202e94ddee8c0b6777849e36ea644b1d
Fixes: Id67259ec9ac4c2c33bd0eef3f64450affbe3fb9f
Fixes: OS#5243
---
M src/common/measurement.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/25651/1

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 7dc0bf1..87e853e 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -805,6 +805,8 @@
 
 	timing_offset = ms_to_valid(lchan) ? ms_to2rsl(lchan, le) : -1;
 	rc = rsl_tx_meas_res(lchan, (uint8_t *)gh, len, timing_offset);
+	if (rc == 0) /* Count successful transmissions */
+		lchan->meas.res_nr++;
 
 	/* Run control loops now that we have all the information: */
 	/* 3GPP TS 45.008 sec 4.2: UL L1 SACCH Header contains TA and
@@ -850,7 +852,6 @@
 		lchan_bs_pwr_ctrl(lchan, (const struct gsm48_hdr *) gh);
 
 	/* Reset state for next iteration */
-	lchan->meas.res_nr++;
 	lchan->tch.dtx.dl_active = false;
 	lchan->meas.flags &= ~LC_UL_M_F_OSMO_EXT_VALID;
 	lchan->meas.flags &= ~LC_UL_M_F_L1_VALID;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25651
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I441adb4b202e94ddee8c0b6777849e36ea644b1d
Gerrit-Change-Number: 25651
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210930/ba0c2fa1/attachment.htm>


More information about the gerrit-log mailing list