This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25548 )
Change subject: card_handler: make reader (sl) operations optional.
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/pysim/+/25548/1/pySim/card_handler.py
File pySim/card_handler.py:
https://gerrit.osmocom.org/c/pysim/+/25548/1/pySim/card_handler.py@38
PS1, Line 38: print("Ready for Programming: Insert card now (or CTRL-C to cancel)")
> Does it make sense to print this message, when sl is not set? It looks like it makes more sense to m […]
the CardHandler class suffers a bit from design problems. When we use the normal CardHandler, ther is indeed no reason why not giving it an sl object. I just thought i could make it optional here as well, just for completeness but I think we should drop that.
For CardHandlerAuto pySim-shell is not using the sl object and pySim-prog is using it. There we need this feature. In any case, there at least the message printing makes sense since it executes the get command (self.__exec_cmd(self.cmds['get'])) so I think everything is fine here.
One big problem is that the mechanically automated reader we are using has technical problems with its built in reader. If the built in reader would behave like any other reader things would be much more straight forward.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/25548
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0f793aec51751b7c7b87d55b66326cce9970274e
Gerrit-Change-Number: 25548
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Sep 2021 14:01:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210929/11b42fd3/attachment.htm>