This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25629 ) Change subject: pdch: refactor rcv_control_ack() with a switch statement ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/25629/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25629/1/src/pdch.cpp@350 PS1, Line 350: OSMO_ASSERT(ul_tbf); > Could the ASSERT cause aborts where we would have only logged an error before (due to if ul_tbf and […] well, theoretically it should not happen since a DL TBF should have never allocated a POLL of this type, it just doesn't make sense, hence the assert here makes more sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7e4a88d6e004bbb7974595320ed73742162c7ad7 Gerrit-Change-Number: 25629 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: daniel <dwillmann at sysmocom.de> Gerrit-Comment-Date: Tue, 28 Sep 2021 19:56:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210928/4168688b/attachment.htm>