This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25622 ) Change subject: gsmtap: allow 127.0.0.x local listeners ...................................................................... Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c@1137 PS1, Line 1137: __linux__ > Does it make sense to make it conditional given that we don't care about anything else than linux? Yes it makes sense. Not caring and actively supporting other platforms doesn't mean we should make it more difficult for them if it's easy to keep compatibility. https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c@1141 PS1, Line 1141: uint32_t address = ((struct sockaddr_in *)a)->sin_addr.s_addr; /* already BE */ what about ipv6? https://gerrit.osmocom.org/c/libosmocore/+/25622/1/src/socket.c@1160 PS1, Line 1160: if (sockaddr_is_local_routed(addr)) IIRC the 127.0.0.X automatically working in linux only happens with ipv4, not with ipv6 (probably due to legacy behavior). So it probably makes sense to move this function after the loop below, and then check addr->af_family and only call this function in case it's AF_INET. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1043dfd8075f14481011f43db45c943e9320413c Gerrit-Change-Number: 25622 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 28 Sep 2021 10:08:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210928/c8ec27d0/attachment.htm>