Change in osmo-bts[master]: osmo-bts-trx: remove an 'else' branch in _sched_dl_burst()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

fixeria gerrit-no-reply at
Mon Sep 27 16:02:27 UTC 2021

fixeria has submitted this change. ( )

Change subject: osmo-bts-trx: remove an 'else' branch in _sched_dl_burst()

osmo-bts-trx: remove an 'else' branch in _sched_dl_burst()

When I introduced this branch in change [1], I was under assumption
that PDCHs never have an associated 'struct gsm_lchan'.  This is
incorrect: the association actually happens during PDCH activation,
i.e. when osmo-pcu establishes connection over the PCUIF.

Enforcing attenuation of 0 dB for other channel types makes no sense.

[1] I3dcee6e910ccc61c5c63c728db9ea04327e2fc98

Change-Id: I77a839725f22be1be4a025f579c4c9ccdfb53460
M src/common/scheduler.c
1 file changed, 0 insertions(+), 2 deletions(-)

  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 36eaa68..a07ef68 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -1327,8 +1327,6 @@
 	/* BS Power reduction (in dB) per logical channel */
 	if (l1cs->lchan != NULL)
 		br->att = l1cs->lchan->bs_power_ctrl.current;
-	else /* Ensure no attenuation in the absence of lchan (e.g. on PDCH) */
-		br->att = 0;
 	/* encrypt */
 	if (br->burst_len && l1cs->dl_encr_algo) {

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I77a839725f22be1be4a025f579c4c9ccdfb53460
Gerrit-Change-Number: 25602
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list