This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25602 ) Change subject: osmo-bts-trx: remove an 'else' branch in _sched_dl_burst() ...................................................................... osmo-bts-trx: remove an 'else' branch in _sched_dl_burst() When I introduced this branch in change [1], I was under assumption that PDCHs never have an associated 'struct gsm_lchan'. This is incorrect: the association actually happens during PDCH activation, i.e. when osmo-pcu establishes connection over the PCUIF. Enforcing attenuation of 0 dB for other channel types makes no sense. [1] I3dcee6e910ccc61c5c63c728db9ea04327e2fc98 Change-Id: I77a839725f22be1be4a025f579c4c9ccdfb53460 --- M src/common/scheduler.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 36eaa68..a07ef68 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1327,8 +1327,6 @@ /* BS Power reduction (in dB) per logical channel */ if (l1cs->lchan != NULL) br->att = l1cs->lchan->bs_power_ctrl.current; - else /* Ensure no attenuation in the absence of lchan (e.g. on PDCH) */ - br->att = 0; /* encrypt */ if (br->burst_len && l1cs->dl_encr_algo) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I77a839725f22be1be4a025f579c4c9ccdfb53460 Gerrit-Change-Number: 25602 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210927/d3cc3de2/attachment.htm>