Change in osmo-gbproxy[master]: gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at

daniel gerrit-no-reply at
Mon Sep 27 12:48:18 UTC 2021

daniel has posted comments on this change. ( )

Change subject: gbproxy: Avoid sending STATUS on unexpected BLOCK_ACK

Patch Set 1:

Commit Message: 
PS1, Line 12: 
> I think unsolicited ACKs are typically ignored by many protocols. […]
The spec only mentions ACKs for existing BVCs, it says nothing about ACKs for BVCs that we know nothing about. 
File src/gb_proxy.c: 
PS1, Line 1378: 			break;
> it is indeed a bit inconsistent that an UNBLOCK_ACK or RESET_ACK are now handled significantly diffe […]
Agreed, I'll think about this more. Also the rate counter that is increased is completely wrong (invalid RAI, see comment below).

I could keep a list of BVCIs that are gone (but were blocked towards the SGSN). Then we can ignore/accept only the BLOCK_ACKs that we care about and properly reject all others. 
PS1, Line 1497: 	rate_ctr_inc(rate_ctr_group_get_ctr(cfg->ctrg, GBPROX_GLOB_CTR_INV_RAI));
see here

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ic9f34a27412d6e15ca1198ee140f66a076b5c6b6
Gerrit-Change-Number: 25577
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: lynxis lazus <lynxis at>
Gerrit-CC: osmith <osmith at>
Gerrit-Comment-Date: Mon, 27 Sep 2021 12:48:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at>
Comment-In-Reply-To: laforge <laforge at>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list