Change in libosmocore[master]: refactor stat_item: get rid of FIFO and "skipped" error

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/25464 )

Change subject: refactor stat_item: get rid of FIFO and "skipped" error
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/25464/5/include/osmocom/core/stat_item.h 
File include/osmocom/core/stat_item.h:

https://gerrit.osmocom.org/c/libosmocore/+/25464/5/include/osmocom/core/stat_item.h@17 
PS5, Line 17: struct osmo_stat_item_period {
> Maybe it's a good opportunity to move these structs to an internal, non-public header :D
not possible, because osmo_stat_item is not opaque, and needed to set stat item values


https://gerrit.osmocom.org/c/libosmocore/+/25464/5/include/osmocom/core/stat_item.h@132 
PS5, Line 132: /* DEPRECATION: up until libosmocore 1.5.1, this API also defined
> I'd really drop this. […]
disagree. if we break our own principles, rather be upfront about it.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/25464
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I137992a5479fc39bbceb6c6c2af9c227bd33b39b
Gerrit-Change-Number: 25464
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Sep 2021 12:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210925/3cefc53d/attachment.htm>