Change in osmo-bts[master]: Revert "bts-trx: Keep the process ongoing trying to reconnect on Abis...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 23 21:02:07 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25564 )

Change subject: Revert "bts-trx: Keep the process ongoing trying to reconnect on Abis link down"
......................................................................

Revert "bts-trx: Keep the process ongoing trying to reconnect on Abis link down"

This reverts commit 0c44a9219762eef3d23a0d9f6ed8d4164ca5bccc.

Change-Id: Ib367d5ddfaccfad3f1b6acc53abf25a0f1834255
---
M src/osmo-bts-trx/l1_if.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  neels: I would prefer this is not merged as is



diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index 8263cab..f35c9ba 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -195,11 +195,10 @@
 	osmo_fsm_inst_dispatch(trx->bb_transc.mo.fi, NM_EV_DISABLE, NULL);
 }
 
+/* on RSL failure, deactivate transceiver */
 void bts_model_abis_close(struct gsm_bts *bts)
 {
-	/* Go into shutdown state deactivating transceivers until Abis link
-	 * becomes up again */
-	bts_shutdown_ext(bts, "Abis close", false);
+	bts_shutdown(bts, "Abis close");
 }
 
 int bts_model_adjst_ms_pwr(struct gsm_lchan *lchan)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib367d5ddfaccfad3f1b6acc53abf25a0f1834255
Gerrit-Change-Number: 25564
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210923/eb97c3c3/attachment.htm>


More information about the gerrit-log mailing list